Repository navigation
DEV-971: #343 review fixes - leave byte 233 out before a read, one NACK handler, renumber tests - #351
Conversation
… tests From the review of #343: - A Bluetooth configuration write before any read sent a Shimmer3R's byte 233 (DEV-99 audio mode and gain, DEV-1413 sound level) as 0, which turned the unit's audio mode off. It is now left out as byte 232 is, unless it was read or the sound level is turned on, on the same firmware. writeMem() takes a list of bytes to leave out. 3 of the 5 tests in API_00047_AudioConfigWriteTest fail without it. - The event channel probe's NACK now goes through processNackFromCommand(), which marks the event channel unsupported and does not report the NACK as a refused command. processEventChannelProbeNack() is gone. - API_00036_ButtonLogModeTest and API_00037_ButtonLogModeConfigWriteTest are now API_00045 and API_00046: master's log-start-refused tests have those numbers. Co-Authored-By: Claude Opus 5.5 <[email protected]>
|
Bench, 13 Nov 2026: the event channel probe on released firmware that NACKs it. A Shimmer3R on LogAndStream v1.1.25, the release without the event channel, over Bluetooth Classic with the 1-byte link CRC the driver sets at connect. Code:
The same check just before, with the unit still on v1.1.26: the probe ACKed, connect took 4.1 s, and a 5 s stream gave 247 packets with the link kept. Not covered:
🤖 Generated with Claude Code |
|
Bench, 13 Nov 2026: a configuration written on connect, before the read. A Shimmer3R on LogAndStream v1.1.25 over Bluetooth Classic, with the 1-byte link CRC. Code: The run:
Run three times. The first attempt never reached the write: COM32 was still busy 3 s after the previous disconnect. The second and third passed; the third added the Not covered:
🤖 Generated with Claude Code |
Brings in #343 as merged, with #351's event channel fixes and renumbered tests. Co-Authored-By: Claude Fable 5.2 <[email protected]>
DEV-971. Fixes for three points from the review comment on #343, into #343's branch, as #349 did for #348. The one defect, byte 233, was first reproduced by tests that failed on the unchanged code.
API_00047_AudioConfigWriteTestfailed[128..231] [234..255]processEventChannelProbeNack()repeatedprocessNackFromCommand()'s unwinding, and only the not-streaming ACK path took itprocessNackFromCommand()handles the probe: it marks the event channel unsupported and does not calleventCommandRefused(). The duplicate is goneAPI_00036_ButtonLogModeTestandAPI_00037_ButtonLogModeConfigWriteTestshared their numbers with master'sAPI_00036_LogStartRefusedTestandAPI_00037_StreamingLogStartRefusedTestAPI_00045andAPI_00046Byte 233
SensorSoundLevel.isAudioConfigKnown()is true once byte 233 has been parsed, or while the sound level is on.ShimmerObject.isAudioConfigKnown()asks it, and is true on hardware without the byte. With the sound level turned on before a read, the byte is still written with bits 0-3 at 0: the host never sets them, and one bit cannot be written on its own.isSupportedSetFeature()(Shimmer3R v1.00.052, Shimmer3 v1.00.017). On Shimmer3R firmware before that, the write still goes in whole chunks, asAPI_00046requires, so byte 233 is still written there. This is unchanged from master.writeMem()'s private overload takes a list of bytes to leave out instead of one. With none, it sends exactly the chunks it did before.Tests
API_00047_AudioConfigWriteTest(new)API_00046_ButtonLogModeConfigWriteTestAPI_00038_EventChannelProbeTesttestclean build, as CI runs it)shadowJar -PmatlabJava8)CI does not run on this base.
On a unit
On a Shimmer3R running LogAndStream v1.1.25 over Bluetooth Classic, at
d7d7fd80:[128, 104]and[234, 22], and the firmware ACKed both pieces. The unit kept its own bytes 232 and 233. Both pieces were stored, and the MAC came back as the unit's own.isEventChannelSupported()was false, the opt-in and the status read were refused without being sent, the link stayed up, and a stream ran normally afterwards.Not run on a unit: firmware with the event channel (v1.1.26), and a Shimmer3.
Still open from the review
Shimmer.java's streaming parser knows the record frame. The guard, refusingwriteEventStream()there, can only compile once a driver release containing DEV-971 is pinned, so it belongs with that pin bump.API_00009,API_00023,API_00031) are left alone.🤖 Generated with Claude Code