Repository navigation
Conversation
Docked, a Verisense in NeuroLynQ mode answers VER with its own hardware ID (61 to 68) and the GQ's firmware ID, GQ_802154. It answers and streams as a GQ does, but the host decided GQ-ness by hardware ID alone. So the bench node (hardware 68, v2.1.1) stayed an unrecognised device with "Unknown" firmware, and NeuroLynQ could not offer it for pairing. ShimmerVerObject - isVerisenseNeuroLynQ(): Verisense hardware running GQ_802154, the one firmware ID that identifies it. - isShimmerGenGq() includes it. Every caller, some 60 across the stack, uses the no-argument form, so this is the one place that decides. - isShimmerGenVerisense() excludes it. It sends GQ data, already scaled to the GQ's ADC, so SensorGSR must take the GQ's ADC properties rather than a Verisense's. - isSupportedConfigViaUart() and isSupportedRtcConfigViaUart() include it, so a dock reads and writes its InfoMem image and clock as it does a GQ's. The node implements both commands. - isSupportedSdCardAccess(), keyed on the GQ's firmware ID, excludes it: it has no SD card, and its USB has no mass storage. - Its firmware label follows, as "GQ_802154". Configuration: the GQ sensor compatibility lists match GQs by hardware, so each gains an entry matching GQ_802154 on any hardware. Only a NeuroLynQ-mode Verisense needs it. A stock Verisense, firmware VERISENSE, is unchanged. API_00014 covers it, a GQ, and every Verisense hardware ID. Co-Authored-By: Claude Opus 5.5 <[email protected]>
Member
Author
|
Superseded by #308, which carries this PR's commit unchanged, together with the rest of DEV-1047's Java driver changes, as one PR for review. Closed without merging; the branch is kept. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of DEV-1047. Stacked on #303, which is stacked on #302, so this PR shows only its own commit.
Why
Docked, a NeuroLynQ-mode Verisense answers
VERwith its own hardware ID (61–68) and the GQ's firmware ID (GQ_802154). It is built to be indistinguishable from a docked GQ. The host, though, decided GQ-ness by hardware ID alone.So the bench node (hardware 68, v2.1.1) stayed a generic
ShimmerShellwith "Unknown" firmware. NeuroLynQ's hardware panel lists onlyShimmerGQ_802154devices (PanelGQHardware:3275), so it could not offer the node for pairing.The other fix would have been for the firmware to report a GQ hardware ID. That was rejected: the host should recognise the device as it is.
What
ShimmerVerObject— one rule, in one place:isVerisenseNeuroLynQ(): Verisense hardware runningGQ_802154. Firmware ID 9 is used by nothing else; a stock Verisense reports 17.isShimmerGenGq()now includes it. All ~60 callers across the Java stack use the no-argument form, which routes here, so none of them changes.isShimmerGenVerisense()now excludes it. The node sends GQ data, already scaled to the GQ's ADC (its battery reply does the same), soSensorGSRmust take the GQ's ADC properties, not a Verisense's.isSupportedConfigViaUart()andisSupportedRtcConfigViaUart()include it, so a dock reads and writes its InfoMem image and clock as it does a GQ's.isSupportedSdCardAccess()is keyed on the GQ's firmware ID, and now excludes the node. It has no SD card, and its USB has no mass storage.GQ_802154 v2.1.1instead ofUnknown v2.1.1.Configuration: the GQ sensor compatibility lists match GQs by hardware ID. The seven lists that include the GQs gainsvoVerisenseNeuroLynQ, which matchesGQ_802154on any hardware.A stock Verisense (firmware
VERISENSE) is unchanged.Tests
API_00014_VerisenseNeuroLynQVersionTest(8 tests) covers:The Shimmer-Advance-API PR on this branch name checks the
ShimmerGQ_802154that gets built. The fullConsensysApibuild is green locally.Not in this PR
These hardware-ID checks don't go through
isShimmerGenGq():DatabaseHandlerclassifies stored devices by hardware ID only (isDeviceTypeGqand three other checks). Reloading a trial from the DB would therefore drop a node. That fix is proposed separately.PanelConfigureandPanelAdvancedExGkey their GQ ExG options on hardware ID.DialogFirmwareoffers GQ firmware only to GQ hardware, which rightly keeps MSP430 images off the node.ShimmerSDLog,ShimmerObject) doesn't apply: the node has no SD card.🤖 Generated with Claude Code