Repository navigation
DEV-1372: fail the C# HIL's SD-logging item on a docked or USB unit - #229
Merged
Merged
Conversation
Docked, or with USB plugged into a Shimmer3R, LogAndStream ACKs a start of SD logging and then ignores it. stream.log_and_battery passed that way in the 29 Oct release run: BE69 was docked and 2F31 on USB, and neither logged anything. The item now reads the status the connect read (docked: byte 0 bit 0; USB: a Shimmer3R's byte 1 bit 0) and fails before it starts, saying which and to take the unit off the dock and USB. Same check and wording as the Android HIL's checkCanLog (ShimmerAndroidAPI PR 143). The README's items table and setup notes say so. Co-Authored-By: Claude Opus 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Docked, or with USB plugged into a Shimmer3R, LogAndStream ACKs a start of SD logging and then ignores it (Shimmer3 LogAndStream v1.01.002+, Shimmer3R v1.01.004+). In the 29 Oct release run,
stream.log_and_batterypassed on both units without logging anything:Docked:Truein its status). The API marked it not logging, and the item only noted "logging not seen".USB:Plugged). The API showed it logging all the same.What
stream.log_and_batteryis the only item that starts SD logging. Before it configures or starts anything, it checks the status the connect read: bit 0 of the first byte for docked, and bit 0 of a Shimmer3R's second byte for USB. If either is set, it fails at once, saying which, and to take the unit off the dock and USB.This is the same check, with the same wording, as the Android HIL's
checkCanLog(ShimmerResearch/ShimmerAndroidAPI#143).Link.WhyCannotLog(): the API keeps the USB bit in a protected field with no getter, so the suite reads it by reflection, as it already does for the battery reading.Items.CheckCanLog(), called first instream.log_and_battery.tools/hil/README.md: the items table and the setup notes say the item needs an SD card in the unit, off the dock and USB.The suite only. No API change, and no new items.
Tested
run-csharp-hil.ps1 -List).stream.log_and_battery:Docked:Truefor the Shimmer3 in the 29 Oct run.🤖 Generated with Claude Code