Skip to content

CIP-000E: Cholesky VJP NumPy/BLAS primitive + benchmark harness - #1303

Closed
lawrennd wants to merge 1 commit into
mainfrom
cip000E-numpy-blas-primitives
Closed

lawrennd wants to merge 1 commit into
mainfrom
cip000E-numpy-blas-primitives

Conversation

@lawrennd

Copy link
Copy Markdown
Member

Summary

  • Extract cholesky_vjp as a pure NumPy/BLAS reverse-mode Cholesky primitive (no model/paramz coupling).
  • Add parity tests against the triple-loop oracle and Cython implementations.
  • Add benchmarks/cip000E/ harness for runtime / peak-allocation comparisons before flipping the default.
  • Keep Cython as the wired default for backprop_gradient when built; use cholesky_vjp as fallback.

Test plan

  • pytest GPy/testing/test_cython.py::TestCholeskiesBackprop
  • Run python benchmarks/cip000E/run_cholesky_backprop.py on Linux CI / Accept hosts and record results
  • Confirm no behavioural change for callers of backprop_gradient when Cython is built

Extract cholesky_vjp as a NumPy/BLAS numerical primitive with parity
tests against the pure and Cython paths, and add an in-repo harness for
runtime and peak-allocation comparisons before flipping the default.
@lawrennd

Copy link
Copy Markdown
Member Author

Closing for now — keep cip000E-numpy-blas-primitives as a separate branch until we are ready to merge.

@lawrennd lawrennd closed this Nov 16, 2026
@codecov

codecov Bot commented Nov 16, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 94.73684% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 62.25%. Comparing base (7bd4338) to head (16043fa).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1303      +/-   ##
==========================================
+ Coverage   62.22%   62.25%   +0.03%     
==========================================
  Files         206      206              
  Lines       21962    21978      +16     
  Branches     2564     2566       +2     
==========================================
+ Hits        13665    13683      +18     
+ Misses       7675     7674       -1     
+ Partials      622      621       -1     
Flag Coverage Δ
unittests 62.25% <94.73%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant