Repository navigation
CIP-000E Phase 0: fix state-space Cython relative import - #1302
Merged
Merged
Conversation
Load state_space_cython via package-relative import so the extension is available when GPy is installed, and add a smoke test for cython_code_available.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1302 +/- ##
==========================================
+ Coverage 62.16% 62.22% +0.05%
==========================================
Files 206 206
Lines 21962 21962
Branches 2564 2564
==========================================
+ Hits 13653 13665 +12
+ Misses 7682 7675 -7
+ Partials 627 622 -5
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
import state_space_cythoninstate_space_main.pyso the extension loads from the installed package tree (from . import state_space_cython).cython_code_availableis True when the extension is built.Test plan
pytest GPy/testing/test_cython.py::test_state_space_cython_available_when_built(passes with built extension;cython_code_available True)