Repository navigation
Agree MSP when sound can play (TelnetNegotiationCore 4.5.3) - #94
Merged
Merged
Conversation
4.5.3 ships MSPProtocol. TelnetSession registers it only when the session plays media (TelnetSessionOptions.PlaysMsp, set from WorldSession.PlaysMedia) and raises MspChanged from its enabled and disabled callbacks, so MSP !!SOUND/!!MUSIC lines are read as sound requests on a connection that agreed option 90. Without a device the server's WILL MSP is still refused. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]> Claude-Session: https://claude.ai/code/session_01WXyHEoxwX8GurTHxwPinQY
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Grave · project thread
Follow-up to #78. TelnetNegotiationCore 4.5.3 on nuget.org ships
MSPProtocol(TNC #171).TelnetSessionOptions.PlaysMspis off by default and set fromWorldSession.PlaysMedia. When it is on,TelnetSessionregistersMSPProtocoland raisesMspChangedfrom its enabled and disabled callbacks. TheMspTriggerpath from Read MSP sound triggers on connections that agreed MSP #78 then reads!!SOUND/!!MUSIClines on a connection that agreed option 90.WILL MSPis refused. Registering the plugin is how the library says the client plays sound.MspNegotiationTestscovers two cases: a session that plays sound answersDO, thenDONTwhen the server withdraws, and raises true then false; a session that doesn't play sound answersDONTand raises nothing.Tests: Graphics 99, Scripting 68, Web 37, Tui 2088 and Avalonia 211 all pass. Core passes 1346 of 1347; the one failure is
AReadOnlyCacheDirectory_DegradesToMemoryOnly, which always fails when the tests run as root, as they do in this sandbox.Generated by Claude Code