Repository navigation
Take MarkupString 2.18.1 - #1817
Conversation
2.18.1 builds Repeat's text directly, so repeat() and the ljust(), rjust() and center() fills stop concatenating one copy per character. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]> Claude-Session: https://claude.ai/code/session_01DGK2ENFwejRuxQ4am7VoVo
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Warning Review limit reached
This review includes 1 billable file and costs up to $0.25.
Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing. Or wait 44 minutes for your next included review. View limit details
Comment |
Requested by Grave · project thread
Before:
repeat()and theljust()/rjust()/center()fills went through MarkupString 2.18.0'sRepeat, which concatenated one copy per repetition (about 18 bytes and 16-28 ns a character).After: MarkupString 2.18.1 builds the repeated text directly (SharpMUSH/MarkupString#62).
Space.Repeat(1000000)goes from 18.5 ms / 18 MB to 1.0 ms / 2 MB. Output is unchanged.How:
MarkupStringVersion2.18.0 -> 2.18.1 inDirectory.Build.props. Follows #1812, which fixedspace()on its own. RanStringFunctionUnitTests,NumericCompatibilityTests,GuestOutputLimitTests,RestrictedExpressionTests,AlignUnitTests,MushTextTests,MushListTestsandMarkupStringHandlerTestsagainst the published packages: 602 pass.🤖 Generated with Claude Code
https://claude.ai/code/session_01DGK2ENFwejRuxQ4am7VoVo
Generated by Claude Code