Skip to content

Take MarkupString 2.18.1 - #1817

Merged
HarryCordewener merged 1 commit into
mainfrom
claude/markup-repeat-fast-path-gbm3pm
Oct 13, 2026
Merged

HarryCordewener merged 1 commit into
mainfrom
claude/markup-repeat-fast-path-gbm3pm

Conversation

@HarryCordewener

Copy link
Copy Markdown
Member

Requested by Grave · project thread

Before: repeat() and the ljust()/rjust()/center() fills went through MarkupString 2.18.0's Repeat, which concatenated one copy per repetition (about 18 bytes and 16-28 ns a character).

After: MarkupString 2.18.1 builds the repeated text directly (SharpMUSH/MarkupString#62). Space.Repeat(1000000) goes from 18.5 ms / 18 MB to 1.0 ms / 2 MB. Output is unchanged.

How: MarkupStringVersion 2.18.0 -> 2.18.1 in Directory.Build.props. Follows #1812, which fixed space() on its own. Ran StringFunctionUnitTests, NumericCompatibilityTests, GuestOutputLimitTests, RestrictedExpressionTests, AlignUnitTests, MushTextTests, MushListTests and MarkupStringHandlerTests against the published packages: 602 pass.

🤖 Generated with Claude Code

https://claude.ai/code/session_01DGK2ENFwejRuxQ4am7VoVo


Generated by Claude Code

2.18.1 builds Repeat's text directly, so repeat() and the ljust(),
rjust() and center() fills stop concatenating one copy per character.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
Claude-Session: https://claude.ai/code/session_01DGK2ENFwejRuxQ4am7VoVo
@HarryCordewener HarryCordewener self-assigned this Oct 13, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 13, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-13T19:10:29.120094Z e3bc7c1 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@coderabbitai

coderabbitai Bot commented Oct 13, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

  • Run on-demand review

This review includes 1 billable file and costs up to $0.25.

  • Ask an admin to make reviews automatic

Open in CodeRabbit

Reviews can continue after your included limit without a manual trigger. An admin must approve usage-based billing.

Or wait 44 minutes for your next included review.

Check out review usage here.

View limit details

Limit details: You’ve used the included review currently available. Your 60 included PR review attempts over the past 7 days set your current allowance at 1 review per hour.

Learn how review limits work.

Review configuration:

⚙️ Run configuration
  • Configuration used: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Essentials
  • Run ID: cbfd222b-6df1-48e5-86e1-b9c72b3b74d5
📥 Commits

Reviewing files that changed from the base of the PR and between 4a3d0a7 and e3bc7c1.

📒 Files selected for processing: 1
  • Directory.Build.props
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@HarryCordewener
HarryCordewener merged commit 9669f58 into main Oct 13, 2026
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants