Repository navigation
🔄 Auto-Sync: ml-explore/mlx-swift main (5f117a2, 2 commit(s)) - #31
Merged
Merged
Conversation
* switch some tests to Swift Testing - migrate off of xctest onto swift testing - this is round 1
…sults (ml-explore#518) * fix callers of mlx_vector_array_values to handle potentially empty results - if a call to mlx_quantize fails it can produce an empty result - but the calling code expects 2 or more valeus in the array - if using withError to catch the error, this crashes instead - fix by allowing callers to specify the minimum number of arrays they need - those values are not usable, but work fine as stand-ins - fixes ml-explore#516
Automated merge by the upstream-sync workflow. 2 upstream commit(s). Merge with a merge commit, not squash/rebase.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated real merge of
ml-explore/mlx-swiftmain (5f117a2, 2 commit(s) not yet in this fork) intomain. Upstream changes: ml-explore/mlx-swift@78d3cc1...5f117a2Merge this PR with a merge commit ("Create a merge commit"), not squash or rebase. Squashing orphans the upstream commits and the fork commits that downstream repos pin (submodule SHAs).
Upstream commits
5f117a2fix callers of mlx_vector_array_values to handle potentially empty results (#518)(David Koski)075f458switch some tests to Swift Testing (#519)(David Koski)Needs a human look
What was checked
-X ours/theirs); the fork's workflows were restored unchanged.Bot disclosure
Prepared by the
upstream-syncGitHub Actions workflow. The workflow never approves, reviews or merges; no human has reviewed this merge yet.