Repository navigation
chore: bump mlx-swift-lm to e2d15c7 (drop compile shadows) - #247
Merged
Merged
Conversation
Moves the mlx-swift-lm pin from 87232e7 to e2d15c7, the merge of SharpAI/mlx-swift-lm#89. It removes the compile(shapeless:) shadows in CompiledTrace.swift so the Downstream Integration Test on SharpAI/mlx-swift#28 no longer fails with "ambiguous use of compile(shapeless:_:)". Co-Authored-By: Claude Sonnet 5.5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Moves the
mlx-swift-lmsubmodule pin from87232e7toe2d15c7, the merge of SharpAI/mlx-swift-lm#89.Why
#89 removes the four
compile(shapeless:_:)shadows fromCompiledTrace.swift. The umbrella job on SharpAI/mlx-swift#28 checks out SwiftLMmain, so until this pin lands it keeps failing withambiguous use of compile(shapeless:_:)(GPTOSS.swift:96,Gemma4Text.swift:32/38).Scope
Pin change only. This pin builds against the current
mlx-swiftpin3185383e; on that version the 1-, 2- and[MLXArray]shapes ofcompile(shapeless:)have no@Sendableguard until #28 lands.🤖 Generated with Claude Code