Repository navigation
Header: language and mobile menus that work without JS, add README - #12
Merged
Merged
Conversation
Takes over #11: Ahmed's header design and README, with the fixes from the review. - Both menus are <details>/<summary>: they open without JS, and a closed menu is not in the Tab order. HeaderMenus adds Escape, click outside, closing after a link in the mobile menu, and the scroll lock. - Flags from lipis/flag-icons (MIT). The Turkmen flag is a 60x45 PNG, because the SVG is 38 KB. - README: npm run check:size, the deploy section, the flag source. Co-authored-by: Ahmed Batyrov <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Takes over #11 by @ahmedbatyrovv. His header design and his README stay; the fixes from the review on #11 are applied. Ahmed is a co-author of the commit.
Closes #5
Supersedes #11
What changes for visitors
Fixes from the #11 review
public/flags/, taken from lipis/flag-icons (MIT, license file included). The Turkmen flag is the official one, with the guls, the olive branches and the stars. It is a 60×45 PNG (2.5 KB), because the SVG is 38 KB and loads on every Turkmen page.<details>/<summary>. Without JS they open and close, and a closed menu cannot get focus.HeaderMenus.tsxadds Escape, click outside, closing after a link in the mobile menu, and no page scroll while the mobile menu is open.npm run check:size, the deploy section, the flag source.One design change: the mobile menu had two close buttons, one in the panel and one on the dark area. Now there is one: the menu button turns into a close button on top of the dark area. It works without JS too.
Checked
npm run buildandnpm run check:sizepass.<main>of/,/ru/,/projects/and the 404 page are pixel-identical to production.