[Claude] add .claude with web session setup scripts by tdavidcl · Pull Request #2128 · Shamrock-code/Shamrock

tdavidcl · 2026-08-20T14:59:40Z

No description provided.

* Add Claude Code on the web session-start hook Installs the system deps (Boost.context/fiber, LLVM headers, OpenMPI, pre-commit), initializes submodules, and builds AdaptiveCpp + Shamrock (debian-generic.acpp, OpenMP backend) so tests and linters are ready in web sessions. Also fixes get_acpp_target_env(), which raised a TypeError when --backend was omitted because it never returned the default "omp" value. Assisted-by: Claude * Skip the full Shamrock build in the session-start hook A full `shammake` compiles all 462 targets (~40min); only run shamconfigure (which still builds the AdaptiveCpp compiler once) so the session starts quickly, and let Claude build only the target(s) touched by a change, doing a full build/test binary only when tests or the `shamrock` executable are actually needed. Assisted-by: Claude * Document incremental builds in AGENTS.md A full shammake takes ~40min; note that only the touched target should be built (ninja -t targets all lists them), reserving a full build for when tests need to run or the binary needs to execute. Mirrors the same policy now used by the session-start hook. Assisted-by: Claude * Harden session-start hook for the setup-script-box path - Tolerate apt-get update failures: some base images ship extra PPAs (deadsnakes, ondrej/php) that this environment's network policy 403s, which apt escalates to a hard error and previously aborted the whole script under set -e even though the mirrors we need succeed. - Skip the cd into CLAUDE_PROJECT_DIR when it's unset, which happens when the script is pasted into an environment's setup-script box instead of running through the normal session bootstrap. Same treatment for the CLAUDE_ENV_FILE write. Assisted-by: Claude --------- Co-authored-by: Claude <[email protected]>

shamconfigure/pull_reffiles previously ran on every session start, and the AdaptiveCpp compile they trigger on a fresh container takes a few minutes, blocking the whole session on it. The hook now stops after new-env (fast: just generates activate/shamenv_do, no compile) and lets the first real build or test request pay that one-time cost inline via the existing idempotent shamconfigure/shammake guards. Also parallelize the submodule fetch with --jobs. Assisted-by: Claude Co-authored-by: Claude <[email protected]>

Installs clangd-18 alongside the existing AdaptiveCpp/MPI/pre-commit deps and symlinks it to an unversioned `clangd` on PATH, since the Ubuntu package only ships the versioned binary. It picks up build/compile_commands.json (from shamconfigure) and the repo's .clangd config with no extra setup. Assisted-by: Claude

clangd --check on this Ubuntu clangd-18 build only surfaces hard parse errors — verified that plain -Wconversion warnings and .clang-tidy findings never reach its output, even with --clang-tidy forced. Correct CLAUDE.md to say so, and add .claude/tools/clang-tidy-check.py, which strips the SYCL/acpp flags clang-tidy can't parse (mirroring .clangd's CompileFlags.Remove list) and runs clang-tidy-18 directly against a file's build/compile_commands.json entry. Assisted-by: Claude

Ubuntu noble's own repos offer clang/clangd/clang-tidy up to 20 with no external PPA; apt.llvm.org (which would reach the newer releases the .clangd file's >= clangd-21/22 comments and the pre-commit-pinned clang-format v22.1.8 imply) is blocked by this environment's network policy, so 20 is the closest reachable match. Installed as a toolchain fully separate from llvm-18-dev, which stays pinned since that's what AdaptiveCpp is actually built and cached against here — upgrading dev tooling should never risk the build. Verified clangd-20 fixes the .clang-format AlignCaseArrows parse error clangd-18 hit, but --check still only surfaces hard parse errors (not warnings or clang-tidy findings) at 20 same as 18, so clang-tidy-check.py remains the way to get real clang-tidy diagnostics; updated it to invoke clang-tidy-20/clang++-20. Assisted-by: Claude

AdaptiveCpp's CMakeLists.txt supports LLVM up to major version 20 (SEND_ERROR above that without -DACPP_EXPERIMENTAL_LLVM=ON), so there's no need to keep 18 around just for the build once 20 is available. Purged all llvm-18/clang-18/clangd-18 packages, rebuilt AdaptiveCpp from scratch against llvm-20-dev/libclang-20-dev/libomp-20-dev, and verified end-to-end: shamconfigure picks up "Building AdaptiveCpp against LLVM configured from /usr/lib/llvm-20", shammake shamrock links cleanly, and the resulting binary runs. session-start.sh now installs only the LLVM 20 dev packages (plus clang-20/clangd-20/clang-tidy-20 for tooling) instead of a split 18-for-build/20-for-tools setup. Assisted-by: Claude

Drop the "verified end-to-end after purging..." and "verified this holds on both clangd-18 and clangd-20" asides — process history, not information useful to a future session. Assisted-by: Claude

Hardcoding clang-tidy-20/clang++-20 only worked inside this container. Outside Claude Code on the web, the host may have a different (or no) LLVM 20 install. Pick the newest matching clang-tidy-N/clang++-N pair found on PATH instead, falling back to unversioned names, so the script works wherever a clang-tidy/clang++ toolchain is installed. Assisted-by: Claude

That script already does this correctly: it expands each acpp compile command via `acpp --acpp-dryrun` into the actual plain-clang invocation (rather than guessing which flags to strip) and drops plugin flags clang-tidy can't load — it's the same database CI's clang-tidy job builds and runs against. clang-tidy-check.py now regenerates build/clang-tidy.mod when missing or stale and runs the newest clang-tidy found on PATH against it, replacing the previous hand-rolled SYCL-flag-stripping logic. Assisted-by: Claude

github-actions · 2026-08-20T14:59:49Z

Thanks @tdavidcl for opening this PR!

You can do multiple things directly here:
1 - Comment pre-commit.ci run to run pre-commit checks.
2 - Comment pre-commit.ci autofix to apply fixes.
3 - Add label autofix.ci to fix authorship & pre-commit for every commit made.
4 - Add label full-ci to run the full test suite (default is light CI; full CI also runs on Mergify merge-queue branches).
5 - Add label profile-build to run the compile-time build profile job even in light CI.
6 - Add label trigger-ci to create an empty commit to trigger the CI.

Once the workflow completes a message will appear displaying informations related to the run.

Also the PR gets automatically reviewed by gemini, you can:
1 - Comment /gemini review to trigger a review
2 - Comment /gemini summary for a summary
3 - Tag it using @gemini-code-assist either in the PR or in review comments on files

coderabbitai · 2026-08-20T14:59:51Z

Warning

Review limit reached

@tdavidcl, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 36 minutes

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

Wait for the limit to reset, then comment @coderabbitai review or push new commits to the PR.

An organization admin can change what happens after included review limits in Billing.

How do review limits work?

CodeRabbit enforces per-developer PR review limits within each organization.

For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 2920a254-460e-4020-ae4d-66aad635eaba

📥 Commits

Reviewing files that changed from the base of the PR and between 52fbab8 and aaf2a54.

📒 Files selected for processing (4)

.claude/hooks/session-start.sh
.claude/settings.json
.claude/tools/clang-tidy-check.py
CLAUDE.md

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

The repo's check_no_utf8 hook rejects non-ASCII characters in .py files; swap the em dash for a plain hyphen. Assisted-by: Claude

tdavidcl · 2026-08-20T15:11:38Z

@Mergifyio queue

mergify · 2026-08-20T15:13:35Z

Merge Queue Status

✅ Entered queue — 2026-08-20 15:58 UTC · Rule: main queue · triggered by @tdavidcl with the @mergifyio queue command
✅ Checks passed · on draft merge queue: checking main (52fbab8) and [#1989 + #2128] together #2133
✅ Merged — 2026-08-20 21:52 UTC · at aaf2a5441e42da9582d77d4a45fbe9adaff505fc · squash

This pull request spent 5 hours 53 minutes 27 seconds in the queue, including 2 hours 9 minutes 50 seconds running CI.

Required conditions to merge

check-success = all

github-actions · 2026-08-20T16:00:51Z

Workflow report

workflow report corresponding to commit aaf2a54
Commiter email is [email protected]

Light CI is enabled (the default for pull requests). This will only run the basic tests and not the full tests.
Full CI runs if the full-ci label is set, or automatically on Mergify merge-queue branches (mergify/merge-queue/*).
The merge gate job "on PR / all" is skipped in this case. Queue entry uses "on PR / all_light"; full CI runs in the merge queue.

Pre-commit check report

Pre-commit check: ✅

trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check for merge conflicts................................................Passed
check that executables have shebangs.....................................Passed
check that scripts with shebangs are executable..........................Passed
check for added large files..............................................Passed
check for case conflicts.................................................Passed
check for broken symlinks................................................Passed
check yaml...............................................................Passed
detect private key.......................................................Passed
No-tabs checker..........................................................Passed
Tabs remover.............................................................Passed
cmake-format.............................................................Passed
Validate GitHub Workflows................................................Passed
clang-format.............................................................Passed
ruff check...............................................................Passed
ruff format..............................................................Passed
Check doxygen headers....................................................Passed
Check license headers....................................................Passed
Check #pragma once.......................................................Passed
Check SYCL #include......................................................Passed
No ssh in git submodules remote..........................................Passed
No UTF-8 in files (except for authors)...................................Passed

Test pipeline can run.

Clang-tidy diff report

No relevant changes found.
Well done!

You should now go back to your normal life and enjoy a hopefully sunny day while waiting for the review.

Doxygen diff with `main`

Removed warnings : 0
New warnings : 0
Warnings count : 8219 → 8219 (0.0%)

Detailed changes :

tdavidcl and others added 10 commits August 20, 2026 13:42

Merge branch 'Shamrock-code:main' into main

1679597

Trim historical notes from CLAUDE.md

165a681

Drop the "verified end-to-end after purging..." and "verified this holds on both clangd-18 and clangd-20" asides — process history, not information useful to a future session. Assisted-by: Claude

tdavidcl added the pre-commit.ci autofix label Aug 20, 2026

pre-commit-ci Bot removed the pre-commit.ci autofix label Aug 20, 2026

Fix pre-commit check_no_utf8 failure in clang-tidy-check.py

aaf2a54

The repo's check_no_utf8 hook rejects non-ASCII characters in .py files; swap the em dash for a plain hyphen. Assisted-by: Claude

shamrock-code-admin approved these changes Aug 20, 2026

View reviewed changes

mergify Bot added the queued label Aug 20, 2026

This was referenced Aug 20, 2026

merge queue: checking main (52fbab8) and [#2127 + #2128 + #1989] together #2132

Closed

merge queue: checking main (52fbab8) and [#1989 + #2128] together #2133

Closed

tdavidcl added the ready-to-merge label Aug 20, 2026

mergify Bot merged commit ebc09b0 into Shamrock-code:main Aug 20, 2026
40 checks passed

mergify Bot removed the queued label Aug 20, 2026

Navigation Menu

Uh oh!

[Claude] add .claude with web session setup scripts - #2128

[Claude] add .claude with web session setup scripts#2128
mergify[bot] merged 11 commits into
Shamrock-code:mainfrom
tdavidcl:claude/build-directory-listing-emkm6p

tdavidcl commented Aug 20, 2026

Uh oh!

github-actions Bot commented Aug 20, 2026

Uh oh!

coderabbitai Bot commented Aug 20, 2026 •

edited

Loading

Review limit reached

Uh oh!

tdavidcl commented Aug 20, 2026

Uh oh!

mergify Bot commented Aug 20, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Aug 20, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

tdavidcl commented Aug 20, 2026

Uh oh!

github-actions Bot commented Aug 20, 2026

Uh oh!

coderabbitai Bot commented Aug 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review limit reached

Uh oh!

tdavidcl commented Aug 20, 2026

Uh oh!

mergify Bot commented Aug 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge Queue Status

Uh oh!

github-actions Bot commented Aug 20, 2026

Workflow report

Pre-commit check report

Clang-tidy diff report

Doxygen diff with main

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

coderabbitai Bot commented Aug 20, 2026 •

edited

Loading

mergify Bot commented Aug 20, 2026 •

edited

Loading

Doxygen diff with `main`