Skip to content

[Solvergraph] ditch ScalarEdge<T> in favor of IDataEdge<T> - #1931

Draft
tdavidcl wants to merge 1 commit into
Shamrock-code:mainfrom
tdavidcl:ditch_scalar_edge
Draft

[Solvergraph] ditch ScalarEdge<T> in favor of IDataEdge<T>#1931
tdavidcl wants to merge 1 commit into
Shamrock-code:mainfrom
tdavidcl:ditch_scalar_edge

Conversation

@tdavidcl

Copy link
Copy Markdown
Member

I don't even know why ScalarEdge was created in the first place it is just a duplicate of IDataEdge without a reason.
However this create quite a lot of change in the codebase so i will hold this PR until we unsure that the conflicts are limited.

@coderabbitai

coderabbitai Bot commented Jul 18, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: b06a2d90-3356-498f-8a62-0fdb197f63ef

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

Thanks @tdavidcl for opening this PR!

You can do multiple things directly here:
1 - Comment pre-commit.ci run to run pre-commit checks.
2 - Comment pre-commit.ci autofix to apply fixes.
3 - Add label autofix.ci to fix authorship & pre-commit for every commit made.
4 - Add label light-ci to only trigger a reduced & faster version of the CI (need the full one before merge).
5 - Add label trigger-ci to create an empty commit to trigger the CI.

Once the workflow completes a message will appear displaying informations related to the run.

Also the PR gets automatically reviewed by gemini, you can:
1 - Comment /gemini review to trigger a review
2 - Comment /gemini summary for a summary
3 - Tag it using @gemini-code-assist either in the PR or in review comments on files

@github-actions

Copy link
Copy Markdown
Contributor

Workflow report

workflow report corresponding to commit 59d454a
Commiter email is [email protected]

Light CI is enabled. This will only run the basic tests and not the full tests.
Merging a PR require the job "on PR / all" to pass which is disabled in this case.

Pre-commit check report

Pre-commit check: ✅

trim trailing whitespace.................................................Passed
fix end of files.........................................................Passed
check for merge conflicts................................................Passed
check that executables have shebangs.....................................Passed
check that scripts with shebangs are executable..........................Passed
check for added large files..............................................Passed
check for case conflicts.................................................Passed
check for broken symlinks................................................Passed
check yaml...............................................................Passed
detect private key.......................................................Passed
No-tabs checker..........................................................Passed
Tabs remover.............................................................Passed
cmake-format.............................................................Passed
Validate GitHub Workflows................................................Passed
clang-format.............................................................Passed
ruff check...............................................................Passed
ruff format..............................................................Passed
Check doxygen headers....................................................Passed
Check license headers....................................................Passed
Check #pragma once.......................................................Passed
Check SYCL #include......................................................Passed
No ssh in git submodules remote..........................................Passed
No UTF-8 in files (except for authors)...................................Passed

Test pipeline can run.

Doxygen diff with main

Removed warnings : 3
New warnings : 1
Warnings count : 8059 → 8057 (-0.0%)

Detailed changes :
- src/shamrock/include/shamrock/solvergraph/ScalarEdge.hpp:24: warning: Compound shamrock::solvergraph::ScalarEdge is not documented.
+ src/shamrock/include/shamrock/solvergraph/ScalarEdge.hpp:24: warning: Member ScalarEdge (typedef) of namespace shamrock::solvergraph is not documented.
- src/shamrock/include/shamrock/solvergraph/ScalarEdge.hpp:26: warning: Member IEdgeNamed(std::string name, std::string texsymbol) (function) of class shamrock::solvergraph::ScalarEdge is not documented.
- src/shamrock/include/shamrock/solvergraph/ScalarEdge.hpp:28: warning: Member value (variable) of class shamrock::solvergraph::ScalarEdge is not documented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant