[Solvergraph] ditch ScalarEdge<T> in favor of IDataEdge<T> - #1931
[Solvergraph] ditch ScalarEdge<T> in favor of IDataEdge<T>#1931tdavidcl wants to merge 1 commit into
Conversation
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Repository UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
Thanks @tdavidcl for opening this PR! You can do multiple things directly here: Once the workflow completes a message will appear displaying informations related to the run. Also the PR gets automatically reviewed by gemini, you can: |
Workflow reportworkflow report corresponding to commit 59d454a Light CI is enabled. This will only run the basic tests and not the full tests. Pre-commit check reportPre-commit check: ✅ Test pipeline can run. Doxygen diff with
|
I don't even know why ScalarEdge was created in the first place it is just a duplicate of IDataEdge without a reason.
However this create quite a lot of change in the codebase so i will hold this PR until we unsure that the conflicts are limited.