Repository navigation
ci(tests): run the group and lobby Sweettest suites - #170
Merged
Merged
Conversation
Soushi888
force-pushed
the
chore/160-ci-group-lobby-sweettest
branch
from
November 4, 2026 00:48
ddc0922 to
b9b1417
Compare
Soushi888
marked this pull request as ready for review
November 4, 2026 01:26
Collaborator
Author
Review APPROVE at head b9b1417, merging under Soushi's explicit
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
sweettestjob inbuild.ymlran onlynondominium_sweettest, so the Group and Lobby DNAs were tested nowhere but on a laptop. This PR adds their suites as further shards of the same job:groupandndo_anchorfromgroup_sweettestat--test-threads 6, andlobbyfromlobby_sweettestat--test-threads 1. A failure in any of them turns thesweettestcheck red, ande2e(which needssweettest) does not start. The existing nondominium shards from #152 are untouched.Turning the lobby suite on exposed a real defect in it: all five lobby tests shared one network, so on a hosted runner two to three of them failed with
Connection Closedor a consistency timeout. Each test now gets its own network seed, the way the Group suite already does. With that, the lobby shard is green.Changes
package,targetandthreads.PACKAGEandTHREADSfrom the matrix, defaulting tonondominium_sweettestand2, so the six existing entries stay as they were.dnas/lobby/tests/src/common/conductors.rs:unique_seed()(same shape as the Group suite's) andwith_network_seedon the Lobby DNA, so no two tests share a DHT. Test code only; no zome or DNA change.documentation/TEST_COMMANDS.md: a short "Sweettest in CI" section listing which shard runs which binary.Decisions
e2ewould need a secondneeds:. Matrix entries reuse all of it.package: nondominium_sweetteston the six existing entriesgroupis 13 tests andndo_anchoris 11, two conductors per test. Separate shards keep wall clock near the slowest binary, as #152 did.#[ignore]the two failing lobby testsCLAUDE.mdandTEST_COMMANDS.mdgive that figure for the suite. The 2-thread cap in the job comment was measured on the nondominium target (OOM-kill at 6 threads), not on these. The runs below show the group shard completing at 6 threads on a hosted runner (389 s and 200 s).How to test
CI is the test. The gate was proven on this branch before merge:
groupshard failed on exactly that test (12 passed, 1 failed), thesweettestcheck went red ande2ewas skipped: red run 41744225698. The same break failed the same way in run 41740048680.Documentation
documentation/TEST_COMMANDS.md: new "Sweettest in CI" section.Related
Closes #160
Pre-open review
READY TO OPEN. Reviewed against
origin/devat 7faf650 (3 files, 34 insertions, 3 deletions).ci(tests): ..., imperative, scoped); no vendor attribution, no co-author line, no em-dashes.TEST_COMMANDS.md).dev(GitHub reports the PR mergeable and clean).threadson those two entries.