Gate binary data on the role's client/state object - #204
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since role objects became optional per
client/statemessage, a client can satisfy "has sent its initialclient/state" withavailablealone and deliver theplayerobject later on activation. The binary-data gate inmessaging.mdtherefore opened before the server knewoutput_delay_ms,required_lead_time_ms, ormin_buffer_ms.The gate now requires the role's
client/stateobject before that role's binary data. All built-in roles that receive binary data define one, so only application-specific roles without a state object fall back to the initialclient/state. This matches thestream/startrule that waits for the activation update before starting a role's stream.