Remove the already-paired pairing entry - #192
Merged
Merged
Conversation
A code-based pairing runs over a Sentinel-keyed connection only. A server that wants a fresh credential unpairs and pairs again; the long-term PSK no longer admits the 'pairing' activity. Device-presence verification rode on this entry and goes with it; it can return if there is demand. Co-Authored-By: Claude Fable 5 <[email protected]>
maximmaxim345
approved these changes
Sep 1, 2026
maximmaxim345
left a comment
maximmaxim345
left a comment
Member
There was a problem hiding this comment.
Was thinking a bit more of whether we should keep or drop key rotations.
I think use of key rotations is more theoretical than practical:
- If you know you have a compromised client, the best mitigation is not to rotate the key (since you can accidentally just rotate the key of the impostor) but unpairing it from the server, and probably also updating/factory resetting the client.
- What I can see as a proper process is to regularly rotate keys, that will solve part of my first point and will in addition be probably even more secure. But that comes at a severe disadvantage for low cost clients: each rotated key means rewriting persistent storage, causing increased wear.
balloobbot
pushed a commit
to balloobbot/spec
that referenced
this pull request
Sep 1, 2026
The keep-the-entry revert predates Sendspin#192; replaying it over a main that merged Sendspin#192 resurrected the removed text. Co-Authored-By: Claude Fable 5 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the already-paired entry into code-based pairing: a code-based pairing now runs over a Sentinel-keyed connection only, and the long-term PSK no longer admits the
'pairing'activity.A server has no need to run a pairing round over an existing credential: to establish a fresh one it unpairs (
server/unpair) and pairs again. The Pairing PSK flow is unaffected - it still enters from any open connection by re-handshaking to the pairing PSK first, since that is an operator-token-driven fresh pairing.Device-presence verification rode exclusively on this entry and is removed with it. If demand appears, it can come back as its own feature.
Split out of #183 (see the pairing.md discussion) so it can be discussed on its own. Overlaps textually with #183; whichever merges second needs a rebase.