Allow at most one pairing-code method per client - #189
Merged
Conversation
balloobbot
force-pushed
the
one-pairing-code-method
branch
from
August 28, 2026 20:57
bb595ca to
4e38135
Compare
Which pairing method a client implements is its own decision, so the steering paragraph goes; the method descriptions already carry the trade-offs. A client offers static or dynamic, not both. Co-Authored-By: Claude Fable 5 <[email protected]>
Name the methods in the Methods intro so the rule is searchable. State the constraint on supported_pair_methods in both directions: the client MUST NOT list both code methods, and a server that receives both disregards static_pairing_code, so a non-conformant advertisement degrades to the safer method instead of undefined behavior. Co-Authored-By: Claude Fable 5 <[email protected]>
Co-authored-by: Maxim Raznatovski <[email protected]>
Co-Authored-By: Claude Fable 5 <[email protected]>
balloobbot
force-pushed
the
one-pairing-code-method
branch
from
September 2, 2026 13:13
e9c6afa to
1edf355
Compare
The advice stays in the spec until an implementation guide exists to hold it. Lowercase keywords keep it out of conformance, and the clause telling clients to also ship `static_pairing_code` disabled is gone because a client may now offer only one pairing-code method.
maximmaxim345
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #184. Fixes #186.
Two changes to pairing.md's Methods section:
supported_pair_methodsalready carries whatever the client offers; this constrains what may appear there.dynamic_pairing_codegiven an out-channel, SHOULD offerqr_codegiven a display) is changed to a regular non binding "should". Method choice is the client's decision; the method list already describes the trade-offs (out-channel requirement, static-code MITM caveat).Note: overlaps textually with #183, which edits the same paragraph - whichever lands second needs a trivial rebase.