Exempt Dynamo vLLM/SGLang from sign-off engine-first ordering / 签核引擎优先顺序规则豁免 Dynamo vLLM/SGLang - #3667
Conversation
…fier Check 6(b) treated every Dynamo variant as an additional framework, so a dynamo-sglang entry failed when the model and SKU had no plain sglang entry. The ordering rule is meant to put open-source engines ahead of vendor-specific frameworks. Treat vllm, dynamo-vllm, sglang, sglang-disagg and dynamo-sglang as open-source engine entries that never need a prior entry. Require one of them before trt, dynamo-trt, atom or atom-disagg entries, keeping the new-hardware and new-architecture exceptions. Co-Authored-By: Claude Opus 5.5 <[email protected]>
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
| vendor-specific frameworks. Open-source engine entries are every vLLM or SGLang | ||
| deployment, whether served directly or through Dynamo or disaggregated serving: | ||
| `framework:` of `vllm`, `dynamo-vllm`, `sglang`, `sglang-disagg`, or `dynamo-sglang`. |
There was a problem hiding this comment.
🟡 (optional) A future llm-d vLLM master-config entry (framework: llmd-vllm, documented in inferencex-e2e/docs/configuration-procedures.md:220 as the master-entry name for llm-d recipes) will FAIL Check 6(b) as a vendor framework requiring a prior open-source engine entry, even though it is a plain vLLM deployment like dynamo-vllm. The new open-source engine list at line 242 only names vllm, dynamo-vllm, sglang, sglang-disagg, dynamo-sglang, so llmd-vllm falls into "every other engine" (line 244) by omission, wrongly blocking it the same way dynamo-sglang was wrongly blocked before this PR. Fix: enumerate every vLLM/SGLang deployment wrapper (including llmd-vllm) as open-source, or match by engine prefix (vllm*/sglang*) instead of a fixed list.
Why this was flagged
Trigger: a PR adds/updates a framework: llmd-vllm entry in inferencex-e2e/configs/*-master.yaml (the documented path per inferencex-e2e/docs/configuration-procedures.md:220, 'Add/update the llmd-vllm master entry'), with no prior vllm/sglang entry for the same model-prefix/runner. The verifier's Check 6(b) (lines 239-253 of .github/codeowner-signoff-verify-prompt.md) classifies anything not in the open-source list at line 242 as vendor-specific ('every other engine', line 244), so it FAILs this legitimate open-source vLLM deployment and demands a sign-off exception that doesn't apply. No other part of the prompt lists llmd-vllm as exempt. This is the same bug class the PR itself was written to fix for dynamo-sglang (#3629), left open for the llm-d deployment path.
Verification: Nit, latent gap, near pre-existing. The new Check 6(b) open-source engine list at .github/codeowner-signoff-verify-prompt.md:242 lists only vllm, dynamo-vllm, sglang, sglang-disagg, dynamo-sglang, and line 244 classifies "every other engine" as vendor-specific.
2 participants
[by Claude Code]
Clarify the sign-off verifier's engine-first ordering rule (Check 6(b) in
.github/codeowner-signoff-verify-prompt.md), per a decision from the SA admins.The rule puts open-source engines ahead of vendor-specific frameworks. Dynamo is a deployment layer, not a separate engine. Before this change, Check 6(b) listed "dynamo variants" as additional frameworks, so a
dynamo-sglangsubmission failed when the model and SKU had no plainsglangentry. #3629 was rejected this way.After this change:
vllm,dynamo-vllm,sglang,sglang-disagg,dynamo-sglang) are never subject to the ordering rule. For example,dynamo-sglangdoes not need an existingsglangentry.trt,dynamo-trt,atom,atom-disagg, and similar) still need an existing open-source engine entry for the same model and SKU.This changes only the verifier prompt. No benchmark configs or recipes change, so it needs no
perf-changelog.yamlentry or sweep.AI model disclosure
中文
根据 SA 管理员的决定，澄清签核验证器的引擎优先顺序规则（
.github/codeowner-signoff-verify-prompt.md中的 Check 6(b)）。该规则要求开源引擎先于厂商专用框架提交。Dynamo 是部署层，而不是独立的引擎。此前 Check 6(b) 将“dynamo variants”列为额外框架，因此当同一模型和 SKU 没有
sglang条目时，dynamo-sglang提交会被判定失败。#3629 即因此被拒绝。修改后：
vllm、dynamo-vllm、sglang、sglang-disagg、dynamo-sglang）不受该顺序规则约束。例如，dynamo-sglang无需先有sglang条目。trt、dynamo-trt、atom、atom-disagg等）仍需同一模型和 SKU 已有开源引擎条目。本 PR 仅修改验证器提示词，不涉及任何基准配置或 recipe，因此无需
perf-changelog.yaml条目或 sweep。AI 模型披露
🤖 Generated with Claude Code