Skip to content

chore: bump srt-slurm to v2.36.0 and drop the LMCache patch - #3585

Merged
cquil11 merged 1 commit into
mainfrom
chore/srt-slurm-v2.36.0
Sep 29, 2026
Merged

cquil11 merged 1 commit into
mainfrom
chore/srt-slurm-v2.36.0

Conversation

@cquil11

@cquil11 cquil11 commented Sep 29, 2026

Copy link
Copy Markdown
Collaborator

Bumps utils/srt-slurm from v2.35.1 to v2.36.0 (7b5863a7) and deletes runners/srt-slurm/patches/507-lmcache-server-atom-sglang.patch.

The patch carried NVIDIA/srt-slurm#507 and #528. #507 shipped in v2.35.1 and #528 in v2.36.0, so the patch no longer applies to the pinned release (setup_srt_slurm runs git apply on every patch and fails on it at v2.35.1).

@github-actions

Copy link
Copy Markdown
Contributor

Thanks for the contribution!

  • Review: If this PR changes files owned by someone other than a repository admin or @SemiAnalysisAI/core, ask one eligible CODEOWNER to complete the latest PR_REVIEW_CHECKLIST.md before contacting a core maintainer on Slack. Follow the template exactly, including As a PR reviewer and CODEOWNER, I have reviewed this and have, so sign-off verification triggers.
  • PR verification: Sweeps only run on labeled PRs. Add full-sweep-fail-fast (strongly recommended); use full-sweep-enabled only when matrix jobs should continue after a failure.
  • After merging: PR authors must ensure all GitHub Actions jobs pass. Transient failures often pass on rerun; see how to rerun failed jobs.
中文

感谢你的贡献!

  • **审阅:**如果 PR 修改的文件归属于仓库管理员及 @SemiAnalysisAI/core 之外的 CODEOWNER,请先联系一位有资格的 CODEOWNER 填写最新的 PR_REVIEW_CHECKLIST.md,再通过 Slack 联系核心维护者。必须严格遵循模板,并保留 As a PR reviewer and CODEOWNER, I have reviewed this and have,才能触发签核验证。
  • **PR 验证:**扫描仅在带有标签的 PR 上运行。强烈建议添加 full-sweep-fail-fast;仅当需要矩阵任务在失败后继续运行时才使用 full-sweep-enabled。
  • **合并后:**PR 作者必须确保所有 GitHub Actions 任务通过。临时性失败通常可以通过重新运行恢复;参见重新运行失败任务的说明。

@cquil11
cquil11 merged commit a6023c5 into main Sep 29, 2026
6 checks passed
@cquil11
cquil11 deleted the chore/srt-slurm-v2.36.0 branch September 29, 2026 18:12

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good — a mechanical version bump with no logic changes.

  • Checked submodule pin update (utils/srt-slurm -> 7b5863a7) matches the new SHA quoted in both RECIPES.md and RECIPES_zh.md, and the bilingual docs stay in sync.
  • Checked patch removal against patches/README.md's own rule ("delete the patch and its row" once merged/included) — the removed row matches the deleted patch file exactly.
  • Checked precedent: an earlier identical bump+patch-drop commit (e82af63, v2.30.0) also shipped without a perf-changelog.yaml entry, so omitting one here follows established convention rather than being an oversight.
  • PR author (cquil11) is a listed CODEOWNER for runners/srt-slurm/patches/.
Extended reasoning...

The change touches only docs (RECIPES.md/RECIPES_zh.md), a submodule pointer bump, and deletion of an obsolete vendor patch plus its README table row — no application code, auth, or security-sensitive surface. Verified the new submodule SHA (7b5863a7) matches the version string quoted in both English and Chinese docs, and confirmed via git history that an earlier equivalent commit (e82af63) made the identical style of change (bump + drop obsolete patch) without a perf-changelog entry, which supports that omission here is consistent with prior practice rather than a gap. The PR author is a CODEOWNER for the patches directory. No bugs were found by the bug hunt, and the two candidate concerns raised were about missing changelog entries, which precedent addresses.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant