-
Notifications
You must be signed in to change notification settings - Fork 313
refactor(launch): port hardware launchers to a pluggable Python launcher #3576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
ec73d1c
refactor(launch): port hardware launchers to a pluggable Python launcher
adibarra a2c073b
Merge remote-tracking branch 'origin/main' into feat/python-launchers
adibarra d18ce8b
test(operatorx): use the clusters runner schema in the generator fixture
adibarra ffc07e1
refactor(launch): resolve models from recipe aliases and normalize sr…
adibarra 33ad5ab
refactor(launch): trim srt driver helpers, comments and tests
adibarra 82d3ae0
fix(launch): default the srt account to the user's Slurm default; iso…
adibarra 2d930e6
fix(launch): request typed GRES on CW clusters and skip --segment for…
adibarra 1069244
fix(launch): let clusters opt single-node srt jobs out of --exclusive
adibarra 6280dc6
fix(launch): give single-node srt jobs the same 2 h health-check budg…
adibarra 1e66256
fix(launch): cluster runtime settings override the runner host's envi…
adibarra c3ce5ae
fix(launch): namespace srtctl jobs, restore pristine model defaults, …
adibarra 52802e5
fix(clusters): mi300x-amd partition is now MI300X-UBUNTU
adibarra 4ce5c26
fix(launch): drop the whole-node CPU request for TRT-LLM srt jobs
adibarra de5fb0e
fix(launch): split the node's CPU budget across TRT-LLM's per-GPU tasks
adibarra fc6a81e
fix(clusters): request b300 CPUs per GPU, not per task
adibarra df1a780
fix(clusters): list the gb200-nv runners that exist
adibarra 95f13d4
Merge origin/main into feat/python-launchers
adibarra 5cccb7c
fix(bench): run the multi-node client with PYTHONSAFEPATH instead of -P
adibarra bede049
chore: drop inline comments from the launcher port
adibarra 34f50c2
refactor(launch): move the srtctl job tag and MI355X RDMA TC into run…
adibarra aeee6a9
Merge remote-tracking branch 'origin/main' into feat/python-launchers
adibarra 1fa6e2f
revert(bench): restore main's comments in files with no code change
adibarra File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 Single-node CI jobs on gb200-nv running dsv41flash sglang agentic-coding at conc>=64 now get only the 500-minute default job timeout instead of 750, so they get killed by GitHub Actions before finishing where the base branch let them run to completion. The refactor's new
timeout-minutesexpression keeps the h200-dgxc 1470-minute bump but drops theinputs.runner == 'cluster:gb200-nv' && ... && 750branch, falling straight to|| 500. Fix: restore a gb200-nv (or equivalent) timeout bump for this workload so its long points keep the time they had on main, alongside the surviving h200-dgxc bump.Why this was flagged
On the base branch (e90870b), benchmark-tmpl.yml:208 sets timeout-minutes to 750 when inputs.runner == 'cluster:gb200-nv' and the config is model-prefix dsv41flash, framework sglang, scenario-type agentic-coding, not eval-only, and conc >= 64. The diff's version of that line keeps only the h200-dgxc 1470-minute clause and falls through to the 500-minute default for every other runner, silently removing the gb200-nv clause. This combination is a real, active config: inferencex-e2e/configs/nvidia-master.yaml defines dsv41flash-fp4-gb200-sglang-agentic-dspark with conc-list up to 128 for gb200-nv sglang. Any dispatched job matching that config on gb200-nv now runs into the GitHub Actions 500-minute step timeout and is cancelled mid-run instead of completing, a regression versus main's 750-minute allowance; no other new timeout mechanism in the diff covers this case.
Verification: normal. The base benchmark-tmpl.yml:208
timeout-minutesexpression had two bump clauses: `inputs.runner == 'cluster:h200-dgxc' && ... && 1470 || inputs.runner == 'cluster:gb200-nv' && fromJSON(inputs.config).model-prefix == 'dsv41flash' && fromJSON(inputs.config).framework == 'sglang' && inputs.scenario-type == 'agentic-coding' && !inputs.eval-only && fromJSON(inputs.config).conc >= 64 && 750…