chore(ci): remove the unused sweep-enabled label / chore(ci):移除未使用的 sweep-enabled 标签 - #3566
Conversation
Remove the bare `sweep-enabled` PR label from all workflow conditions, label lists, Python label sets, tests, and documentation. The trimmed- sweep behavior it activated (--trim-conc) is retained in the matrix generators and e2e-tests.yml workflow_dispatch input for manual use; only the label-driven path is removed. 移除所有工作流条件、标签列表、Python 标签集合、测试和文档中未使用的 `sweep-enabled` PR 标签。该标签激活的精简扫描行为(--trim-conc)在矩阵 生成器和 e2e-tests.yml 的 workflow_dispatch 输入中保留供手动使用; 仅移除标签驱动路径。 Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
There was a problem hiding this comment.
Beyond the inline findings (all stemming from the same scenario of a PR still carrying the legacy sweep-enabled GitHub label), I checked the workflow YAML diffs in run-sweep.yml and trusted-external-sweep.yml for leftover partial references and confirmed the removal is consistent across all label conditions, the TRIM_CONC env var, and the trim-conc dispatch input.
Extended reasoning...
The PR mechanically removes the unused sweep-enabled label from GitHub Actions YAML conditions, Python label sets (lifecycle.py, merge_with_reuse.py), tests, and docs across 14 files; no auth/crypto/permissions logic is touched, only CI label-matching. The three ruled-out candidates all concern the same edge case (PRs that still carry the legacy label after code removal, before the GitHub label itself is deleted separately per the PR description) and are already surfaced as inline findings, so a human should weigh in on whether that transition gap is acceptable.
Summary
Remove the bare
sweep-enabledPR label from all workflow conditions, label lists, Python label sets, tests, and documentation across 14 files. This label drove the "trimmed sweep" (lowest concurrency per parallelism group) via--trim-conc, but was unused.What was removed:
sweep-enabledfrom every label condition inrun-sweep.yml(concurrency group, check-changelog, setup, upload-changelog-metadata, comment-unofficial-run-visualizer)sweep-enabledfromtrusted-external-sweep.yml(dispatch condition, primaryLabels set); itstrim-concdispatch input now always passes'false'TRIM_CONCenv var and--trim-concflag pass fromrun-sweep.ymlsetup step (it was only ever true viasweep-enabled)sweep-enabledfromSWEEP_LABELSinlifecycle.pyandSWEEP_LABEL_NAMESinmerge_with_reuse.pysweep-enabledreplaced with remaining labelsWhat was kept:
--trim-concflag andtrim_conc()function ininfx/matrix/plan.pyandinfx/matrix/generate.py-- becausee2e-tests.ymlstill exposestrim-concas aworkflow_dispatch/workflow_callinput for manual usetrim-concinput ine2e-tests.yml(both workflow_dispatch and workflow_call)full-sweep-enabled,non-canary-full-sweep-enabled,full-sweep-fail-fast,full-sweep-fail-fast-no-canaryAI model disclosure: Claude Opus 5.5 (1M context) (
claude-opus-4-6)中文
概述
从 14 个文件中移除所有工作流条件、标签列表、Python 标签集合、测试和文档中的裸
sweep-enabledPR 标签。该标签通过--trim-conc驱动"精简扫描"(每个并行分组仅运行最低并发),但已不再使用。已移除内容:
run-sweep.yml中所有标签条件里的sweep-enabled(并发组、check-changelog、setup、upload-changelog-metadata、comment-unofficial-run-visualizer)trusted-external-sweep.yml中的sweep-enabled(调度条件、primaryLabels 集合);trim-conc调度输入现在始终传'false'run-sweep.ymlsetup 步骤中的TRIM_CONC环境变量和--trim-conc标志传递(仅在sweep-enabled下为 true)lifecycle.py的SWEEP_LABELS和merge_with_reuse.py的SWEEP_LABEL_NAMES中的sweep-enabledsweep-enabled的测试参数化已替换为剩余标签保留内容:
infx/matrix/plan.py和infx/matrix/generate.py中的--trim-conc标志和trim_conc()函数——因为e2e-tests.yml仍将trim-conc作为workflow_dispatch/workflow_call输入供手动使用e2e-tests.yml中的trim-conc输入(workflow_dispatch 和 workflow_call 两种)full-sweep-enabled、non-canary-full-sweep-enabled、full-sweep-fail-fast、full-sweep-fail-fast-no-canary🤖 Generated with Claude Code