Skip to content

chore(ci): remove the unused sweep-enabled label / chore(ci):移除未使用的 sweep-enabled 标签 - #3566

Merged
functionstackx merged 1 commit into
mainfrom
chore/remove-sweep-enabled-label
Sep 29, 2026
Merged

functionstackx merged 1 commit into
mainfrom
chore/remove-sweep-enabled-label

Conversation

@functionstackx

Copy link
Copy Markdown
Collaborator

Summary

Remove the bare sweep-enabled PR label from all workflow conditions, label lists, Python label sets, tests, and documentation across 14 files. This label drove the "trimmed sweep" (lowest concurrency per parallelism group) via --trim-conc, but was unused.

What was removed:

  • sweep-enabled from every label condition in run-sweep.yml (concurrency group, check-changelog, setup, upload-changelog-metadata, comment-unofficial-run-visualizer)
  • sweep-enabled from trusted-external-sweep.yml (dispatch condition, primaryLabels set); its trim-conc dispatch input now always passes 'false'
  • TRIM_CONC env var and --trim-conc flag pass from run-sweep.yml setup step (it was only ever true via sweep-enabled)
  • sweep-enabled from SWEEP_LABELS in lifecycle.py and SWEEP_LABEL_NAMES in merge_with_reuse.py
  • References from all documentation (AGENT_OPERATIONS.md, README.md, ci-procedures.md/zh, testing.md/zh)
  • Test parametrizations using sweep-enabled replaced with remaining labels

What was kept:

  • The --trim-conc flag and trim_conc() function in infx/matrix/plan.py and infx/matrix/generate.py -- because e2e-tests.yml still exposes trim-conc as a workflow_dispatch / workflow_call input for manual use
  • The trim-conc input in e2e-tests.yml (both workflow_dispatch and workflow_call)
  • The four remaining primary labels: full-sweep-enabled, non-canary-full-sweep-enabled, full-sweep-fail-fast, full-sweep-fail-fast-no-canary
  • The GitHub label itself (will be removed separately)

AI model disclosure: Claude Opus 5.5 (1M context) (claude-opus-4-6)

中文

概述

从 14 个文件中移除所有工作流条件、标签列表、Python 标签集合、测试和文档中的裸 sweep-enabled PR 标签。该标签通过 --trim-conc 驱动"精简扫描"(每个并行分组仅运行最低并发),但已不再使用。

已移除内容:

  • run-sweep.yml 中所有标签条件里的 sweep-enabled(并发组、check-changelog、setup、upload-changelog-metadata、comment-unofficial-run-visualizer)
  • trusted-external-sweep.yml 中的 sweep-enabled(调度条件、primaryLabels 集合);trim-conc 调度输入现在始终传 'false'
  • run-sweep.yml setup 步骤中的 TRIM_CONC 环境变量和 --trim-conc 标志传递(仅在 sweep-enabled 下为 true)
  • lifecycle.py 的 SWEEP_LABELS 和 merge_with_reuse.py 的 SWEEP_LABEL_NAMES 中的 sweep-enabled
  • 所有文档中的引用(AGENT_OPERATIONS.md、README.md、ci-procedures.md/zh、testing.md/zh)
  • 使用 sweep-enabled 的测试参数化已替换为剩余标签

保留内容:

  • infx/matrix/plan.py 和 infx/matrix/generate.py 中的 --trim-conc 标志和 trim_conc() 函数——因为 e2e-tests.yml 仍将 trim-conc 作为 workflow_dispatch / workflow_call 输入供手动使用
  • e2e-tests.yml 中的 trim-conc 输入(workflow_dispatch 和 workflow_call 两种)
  • 四个剩余主标签:full-sweep-enabled、non-canary-full-sweep-enabled、full-sweep-fail-fast、full-sweep-fail-fast-no-canary
  • GitHub 标签本身(将单独移除)

🤖 Generated with Claude Code

Remove the bare `sweep-enabled` PR label from all workflow conditions,
label lists, Python label sets, tests, and documentation. The trimmed-
sweep behavior it activated (--trim-conc) is retained in the matrix
generators and e2e-tests.yml workflow_dispatch input for manual use;
only the label-driven path is removed.

移除所有工作流条件、标签列表、Python 标签集合、测试和文档中未使用的
`sweep-enabled` PR 标签。该标签激活的精简扫描行为(--trim-conc)在矩阵
生成器和 e2e-tests.yml 的 workflow_dispatch 输入中保留供手动使用;
仅移除标签驱动路径。

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beyond the inline findings (all stemming from the same scenario of a PR still carrying the legacy sweep-enabled GitHub label), I checked the workflow YAML diffs in run-sweep.yml and trusted-external-sweep.yml for leftover partial references and confirmed the removal is consistent across all label conditions, the TRIM_CONC env var, and the trim-conc dispatch input.

Extended reasoning...

The PR mechanically removes the unused sweep-enabled label from GitHub Actions YAML conditions, Python label sets (lifecycle.py, merge_with_reuse.py), tests, and docs across 14 files; no auth/crypto/permissions logic is touched, only CI label-matching. The three ruled-out candidates all concern the same edge case (PRs that still carry the legacy label after code removal, before the GitHub label itself is deleted separately per the PR description) and are already surfaced as inline findings, so a human should weigh in on whether that transition gap is acceptable.

@functionstackx
functionstackx merged commit 6e2a3de into main Sep 29, 2026
6 checks passed
@functionstackx
functionstackx deleted the chore/remove-sweep-enabled-label branch September 29, 2026 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant