CollectiveX: point mi300x at the compute-0 partition - #3538
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
LGTM, straightforward config fix.
What was reviewed: the single-line change in experimental/CollectiveX/configs/platform_config.json, which renames the mi300x entry's operator.partition value from "compute" to "compute-0". Confirmed this is a pure JSON data value change with no code, schema, or test modifications, and no other platform entries are affected.
Extended reasoning...
The diff touches exactly one line in a JSON config file for an experimental benchmarking tool, changing a Slurm partition name string; there is no code, auth, or security-sensitive surface involved. The change is mechanical and self-contained, matching the approval criteria for simple config tweaks, and no CODEOWNER or outstanding reviewer objections were found.
c0d7466 to
e7a254a
Compare
e7a254a to
03e2556
Compare
03e2556 to
98e4f5b
Compare
The default graph usage mode (2, mixing) wraps every captured collective in an external event wait and record. Graphed HT decode captures one host collective per pair, the routing ncclAllGather, and the h100 EP8 trace showed ~14us idle before it, making the graphed pair period 1.14x eager. Mode 1 (one graph at a time, never concurrent with uncaptured work on the communicator) removes it. Graphed HT decode rows carry the -gum1 generation suffix.
The mi300x-amd runners submit to a cluster whose partition is compute-0 (as runners/launch_mi300x-amd.sh and runners/srt-slurm/mi300x-amd.yaml already use); the registry's "compute" failed every mi300x shard at salloc.
98e4f5b to
6895e28
Compare
1 participant
Stacked on #3537.
platform_config.jsonsent mi300x shards to Slurm partitioncompute, which does not exist on themi300x-amdcluster. salloc failed with "invalid partition specified: compute", as the mi300x swap-blocks shard did in 36334394602.That cluster's partition is
compute-0, whichrunners/launch_mi300x-amd.shandrunners/srt-slurm/mi300x-amd.yamlalready use. The squash directory (/raid/inferencex/squash) already matched.Validation
Swap-blocks on mi300x (36378673274) is green: salloc now lands on
compute-0, and all 126 cases (63 random + 63 contiguous layout) pass correctness.