-
Notifications
You must be signed in to change notification settings - Fork 309
CollectiveX: run nccl-ep's communicator in NCCL graph usage mode 1 #3537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+43
−5
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟡 (optional) When
COLLX_CUDA_GRAPH=0forces HT decode eager (methodology.md: "restores the eager pipeline"), rows now get the-gum1kernel_generation suffix even though no graph is ever captured.self.kernel_generationis fixed at construction from the staticcuda_graph_supportedproperty (line 159), not fromcuda_graph_enabled, which is whatep_harness.kernel_generation()(ep_harness.py:195-197) checks at record time to append-cudagraph. So an eager-forced decode row is stored asnccl-ep-v02-ht-routed-zc-static-gum1with no-cudagraphsuffix, a new family that no longer pools with the pre-PR eager rows (nccl-ep-v02-ht-routed-zc-static) even though its measured behavior is unchanged (mode 0/1 only diverges from mode 2 when a collective is actually captured). …Why this was flagged
…Fix: gate the
-gum1suffix on the same dynamiccuda_graph_enabledcondition the harness uses for-cudagraph, or apply it inkernel_generation()alongside that suffix, so eager-forced rows keep the pre-existing family name.Trigger: run nccl-ep HT decode with
COLLX_CUDA_GRAPH=0(documented in methodology.md as the eager override). NCCLEPBackend.init (ep_nccl.py:159-162) sets kernel_generation usingself.cuda_graph_supported, a static capability check, before COLLX_CUDA_GRAPH is consulted. ep_harness.kernel_generation() (ep_harness.py:195-197) only appends-cudagraphwhenbackend.cuda_graph_enabledis true, so the stored family becomes...-gum1with no cudagraph marker, distinct from the base branch's plainnccl-ep-v02-ht-routed-zc-staticfor the same eager run. This fragments the durable store's history/trend for that eager configuration with no corresponding behavior change, defeating the suffix mechanism methodology.md describes for preventing incomparable rows from being silently pooled or split.Verification: nit. The mechanism is real and reachable. ep_nccl.py:159-162 sets
self.kernel_generation = f"{type(self).kernel_generation}-gum1"underelif self.cuda_graph_supported:, keyed on the static capability property. ep_nccl.py:112-118 showscuda_graph_supportedonly checks mode=="normal" and phase=="decode"; it never reads COLLX_CUDA_GRAPH. The eager override is instead handled by… | nit.…