[Klaud Cold] refactor: remove SWE-bench Lite eval suite - #3506
Draft
functionstackx wants to merge 2 commits into
Draft
functionstackx wants to merge 2 commits into
functionstackx wants to merge 2 commits into
Conversation
SWE-bench Lite is unused: no master config selects it, and the eval framework has moved past it. Remove the task YAML, scorer, patches, tests, and every reference in workflows, shell scripts, slurm jobs, launcher env passthrough, docs (EN + ZH), and EVALS.md. Drop Modal credential plumbing (MODAL_TOKEN_ID / MODAL_TOKEN_SECRET) which was exclusively consumed by swebench. Deleted: infx/evals/swebench_lite.yaml infx/evals/swebench_score.py infx/evals/patches/patch_swebench_agent.py infx/evals/patches/patch_swebench_scoring.py infx/tests/evals/test_swebench_eval.py Co-Authored-By: Claude Opus 4.6 <[email protected]>
Contributor
|
Thanks for the contribution!
中文感谢你的贡献!
|
The benchmark templates no longer declare these secrets, and GitHub rejects reusable-workflow calls that pass undeclared secrets. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
Collaborator
|
Heads-up: #3576 (merged) replaced the bash launchers with a Python launcher, so this PR will conflict when you merge |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the SWE-bench Lite eval suite and every reference to it across the codebase.
SWE-bench Lite is unused -- no master config selects it, and the eval framework has moved past it.
Deleted files (5)
infx/evals/swebench_lite.yaml-- task definitioninfx/evals/swebench_score.py-- scorerinfx/evals/patches/patch_swebench_agent.py-- agent runtime patchinfx/evals/patches/patch_swebench_scoring.py-- scoring runtime patchinfx/tests/evals/test_swebench_eval.py-- dedicated test moduleEdited files (28)
benchmark-tmpl.yml,benchmark-multinode-tmpl.yml,e2e-tests.yml-- removed swebench inputs, env vars, secrets, artifact globsbenchmark_lib.sh(removed ~280-line swebench function + dispatch case),runtime_settings.sh,srt_eval.shlaunch_h100-cr.sh,launch_mi325x-tw.sh-- removed SWEBENCH_/MODAL_ docker env passthroughslurm_utils.sh,amd_utils/job.slurm,amd_utils/submit.sh,llm-d/job.slurm,llm-d/submit.shtest_run_eval_dispatch.py(~470 lines of swebench/modal tests removed + unusedsignalimport),test_eval_patches.py(dead_load_patch_modulehelper + unused imports),test_generate_sweep_configs.py(docstring)architecture.md,ci-procedures.md,eval-agentx-procedures.md,index.md,results-and-ingestion.mdand their_zh.mdcounterpartsEVALS.md-- removed SWE-bench Lite section, patch entries, task file referencethresholds.yaml-- removedswebench_lite: 0.50entryDeps removed
MODAL_TOKEN_ID/MODAL_TOKEN_SECRET) was exclusively consumed by swebench and is removed everywhere.Validation
bash -npasses on all touched.sh/.slurmfilesuvx ruff check infx/-- all checks passedpytest infx/tests/evals/ infx/tests/matrix/ runners/-- 607 passedgit grep -n -i -E 'swe.?bench|mini.?swe|SWEBENCH' -- . ':!perf-changelog.yaml'-- zero hitsTest plan
Follow-up (41ea1b9)
.github/workflows/run-sweep.yml: stop passingMODAL_TOKEN_ID/MODAL_TOKEN_SECRETtobenchmark-tmpl.yml/benchmark-multinode-tmpl.yml(12 call sites, 24 lines). The templates no longer declare those secrets, and GitHub rejects reusable-workflow calls that pass undeclared secrets, so every sweep would have failed to start. NoMODALreferences remain under.github/. TheMODAL_TOKEN_*repo secrets themselves can be deleted separately.🤖 Generated with Claude Code