[Klaud Cold] Move golden_al_distribution/ into infx/ - #3481
Conversation
GOLDEN_DIR in infx/srt_slurm/synthetic_acceptance.py and the GLM-5.3 TileRT curve path in server_tilert.sh follow the move; every doc, prompt, recipe and config-comment reference is updated. perf-changelog.yaml history is left untouched (append-only). Adds a test that the default GOLDEN_DIR resolves to the committed curves. Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
|
Thanks for the contribution!
中文感谢你的贡献!
|
…distribution-infx # Conflicts: # docs/MODELS.md # docs/MODELS_zh.md # docs/PR_REVIEW_CHECKLIST.md # docs/PR_REVIEW_CHECKLIST_zh.md
There was a problem hiding this comment.
Looks good — a mechanical directory move (golden_al_distribution/ → infx/golden_al_distribution/) with consistent reference updates. Checked the two runtime path changes (infx/srt_slurm/synthetic_acceptance.py's GOLDEN_DIR now uses parents[1], and server_tilert.sh's curve path) — both resolve correctly to the new location, and a new test (test_default_golden_dir_holds_committed_curves) guards the default. Verified no stray root-relative golden_al_distribution/ references remain outside the intentionally-untouched append-only perf-changelog.yaml, and the re-rooted ../ → ../../ links in the moved READMEs are correct.
Extended reasoning...
Pure file-move PR touching docs, comments, configs, and two runtime path references (infx/srt_slurm/synthetic_acceptance.py, benchmarks/multi_node/amd_utils/server_tilert.sh); no security-sensitive surface (no auth, crypto, or injection paths). Verified the path-index arithmetic in the moved Python module and shell script resolves correctly to the new directory, confirmed no leftover broken references outside the historical changelog, and confirmed no CODEOWNERS entries cover these paths. Decided approve because the change is large in file count but mechanical and self-consistent, with a new regression test added for the default GOLDEN_DIR.
This review covers commit 88ac6d8, which is no longer the latest commit on this pull request; later commits are not covered by it.
Summary
Moves
golden_al_distribution/→infx/golden_al_distribution/.Runtime readers updated:
infx/srt_slurm/synthetic_acceptance.py:GOLDEN_DIRis nowparents[1] / "golden_al_distribution"(AgentX synthetic-acceptance selection for every SRT launch).benchmarks/multi_node/amd_utils/server_tilert.sh: the GLM-5.3 TileRT curve path is now${WS_PATH%/benchmarks/*}/infx/golden_al_distribution/….Reference-only updates:
AGENTS.md,docs/MODELS.md/docs/MODELS_zh.md,.github/codeowner-signoff-verify-prompt.md,docs/PR_REVIEW_CHECKLIST*.md,docs/configuration-procedures*.md, plus comments in master configs, the multi-node AMD utils, one multi-node recipe and one SpeedBench script. Relative links inside the moved READMEs are re-rooted (../→../../).perf-changelog.yamlmentions are historical and left untouched (append-only). Comment-only config/recipe edits, so no sweep.Test plan
GOLDEN_DIRresolves toinfx/golden_al_distribution(11 curves)test_default_golden_dir_holds_committed_curves(the existing tests all pass a temp dir, so none guarded the default)utils/test_synthetic_acceptance.py+utils/test_srt_single_node.py(excluding the macOS-only pool-launcher cases): 75 passedgolden_al_distribution/references outside the changelog; 0 broken relative markdown linksNote: main (incl. #3480's
docs/move) is merged in. Open PR #3476 (SpeedBench → srt-slurm) editsgolden_al_distribution/README*.md, so whichever of the two merges second needs main merged in.🤖 Generated with Claude Code