Skip to content

[Klaud Cold] Move golden_al_distribution/ into infx/ - #3481

Merged
functionstackx merged 2 commits into
mainfrom
klaud/move-golden-al-distribution-infx
Sep 26, 2026
Merged

functionstackx merged 2 commits into
mainfrom
klaud/move-golden-al-distribution-infx

Conversation

@functionstackx

@functionstackx functionstackx commented Sep 26, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Moves golden_al_distribution/ → infx/golden_al_distribution/.

Runtime readers updated:

  • infx/srt_slurm/synthetic_acceptance.py: GOLDEN_DIR is now parents[1] / "golden_al_distribution" (AgentX synthetic-acceptance selection for every SRT launch).
  • benchmarks/multi_node/amd_utils/server_tilert.sh: the GLM-5.3 TileRT curve path is now ${WS_PATH%/benchmarks/*}/infx/golden_al_distribution/….

Reference-only updates: AGENTS.md, docs/MODELS.md / docs/MODELS_zh.md, .github/codeowner-signoff-verify-prompt.md, docs/PR_REVIEW_CHECKLIST*.md, docs/configuration-procedures*.md, plus comments in master configs, the multi-node AMD utils, one multi-node recipe and one SpeedBench script. Relative links inside the moved READMEs are re-rooted (../ → ../../).

perf-changelog.yaml mentions are historical and left untouched (append-only). Comment-only config/recipe edits, so no sweep.

Test plan

  • GOLDEN_DIR resolves to infx/golden_al_distribution (11 curves)
  • New test_default_golden_dir_holds_committed_curves (the existing tests all pass a temp dir, so none guarded the default)
  • utils/test_synthetic_acceptance.py + utils/test_srt_single_node.py (excluding the macOS-only pool-launcher cases): 75 passed
  • No remaining root-relative golden_al_distribution/ references outside the changelog; 0 broken relative markdown links

Note: main (incl. #3480's docs/ move) is merged in. Open PR #3476 (SpeedBench → srt-slurm) edits golden_al_distribution/README*.md, so whichever of the two merges second needs main merged in.

🤖 Generated with Claude Code

GOLDEN_DIR in infx/srt_slurm/synthetic_acceptance.py and the GLM-5.3
TileRT curve path in server_tilert.sh follow the move; every doc, prompt,
recipe and config-comment reference is updated. perf-changelog.yaml
history is left untouched (append-only). Adds a test that the default
GOLDEN_DIR resolves to the committed curves.

Co-Authored-By: Claude Opus 5.5 (1M context) <[email protected]>
@github-actions

Copy link
Copy Markdown
Contributor

Thanks for the contribution!

  • Review: If this PR changes files owned by someone other than a repository admin or @SemiAnalysisAI/core, ask one eligible CODEOWNER to complete the latest PR_REVIEW_CHECKLIST.md before contacting a core maintainer on Slack. Follow the template exactly, including As a PR reviewer and CODEOWNER, I have reviewed this and have, so sign-off verification triggers.
  • PR verification: Sweeps only run on labeled PRs. Add full-sweep-fail-fast (strongly recommended); use full-sweep-enabled only when matrix jobs should continue after a failure.
  • After merging: PR authors must ensure all GitHub Actions jobs pass. Transient failures often pass on rerun; see how to rerun failed jobs.
中文

感谢你的贡献!

  • **审阅:**如果 PR 修改的文件归属于仓库管理员及 @SemiAnalysisAI/core 之外的 CODEOWNER,请先联系一位有资格的 CODEOWNER 填写最新的 PR_REVIEW_CHECKLIST.md,再通过 Slack 联系核心维护者。必须严格遵循模板,并保留 As a PR reviewer and CODEOWNER, I have reviewed this and have,才能触发签核验证。
  • **PR 验证:**扫描仅在带有标签的 PR 上运行。强烈建议添加 full-sweep-fail-fast;仅当需要矩阵任务在失败后继续运行时才使用 full-sweep-enabled。
  • **合并后:**PR 作者必须确保所有 GitHub Actions 任务通过。临时性失败通常可以通过重新运行恢复;参见重新运行失败任务的说明。

…distribution-infx

# Conflicts:
#	docs/MODELS.md
#	docs/MODELS_zh.md
#	docs/PR_REVIEW_CHECKLIST.md
#	docs/PR_REVIEW_CHECKLIST_zh.md

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good — a mechanical directory move (golden_al_distribution/ → infx/golden_al_distribution/) with consistent reference updates. Checked the two runtime path changes (infx/srt_slurm/synthetic_acceptance.py's GOLDEN_DIR now uses parents[1], and server_tilert.sh's curve path) — both resolve correctly to the new location, and a new test (test_default_golden_dir_holds_committed_curves) guards the default. Verified no stray root-relative golden_al_distribution/ references remain outside the intentionally-untouched append-only perf-changelog.yaml, and the re-rooted ../ → ../../ links in the moved READMEs are correct.

Extended reasoning...

Pure file-move PR touching docs, comments, configs, and two runtime path references (infx/srt_slurm/synthetic_acceptance.py, benchmarks/multi_node/amd_utils/server_tilert.sh); no security-sensitive surface (no auth, crypto, or injection paths). Verified the path-index arithmetic in the moved Python module and shell script resolves correctly to the new directory, confirmed no leftover broken references outside the historical changelog, and confirmed no CODEOWNERS entries cover these paths. Decided approve because the change is large in file count but mechanical and self-consistent, with a new regression test added for the default GOLDEN_DIR.

This review covers commit 88ac6d8, which is no longer the latest commit on this pull request; later commits are not covered by it.

@functionstackx
functionstackx merged commit d9a41ef into main Sep 26, 2026
4 checks passed
@functionstackx
functionstackx deleted the klaud/move-golden-al-distribution-infx branch September 26, 2026 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant