[GLM-5.2 B200] disable draft MoE FP8 conversion / 关闭 draft MoE FP8 转换 - #3400
edwingao28 wants to merge 10 commits into
Conversation
|
Thanks for the contribution!
中文感谢你的贡献!
|
0c215c1 to
6629a45
Compare
6629a45 to
ead3d05
Compare
|
View unofficial run (performance): https://inferencex.semianalysis.com/inference?unofficialRun=36304573738 View unofficial run (accuracy): https://inferencex.semianalysis.com/evaluation?unofficialRun=36304573738 |
Set SGLANG_NVFP4_CKPT_FP8_NEXTN_MOE=0 so the NextN/MTP draft keeps its shipped precision. 设置 SGLANG_NVFP4_CKPT_FP8_NEXTN_MOE=0,使 NextN/MTP draft 保持原始发布精度。
b3155e8 to
5348346
Compare
There was a problem hiding this comment.
I reviewed this PR and did not find any bugs beyond the two candidates already ruled out. Beyond those, I also checked that prepare_srt_power's override forwarding is consistent end-to-end: apply_srt_recipe passes its trailing arguments straight into plan_commands, so the SRTCTL_RECIPE_ARGS built by prepare_srt_power (and inspected via --inspect-power) are the same arguments later submitted — no override-ordering mismatch. I also checked the new install_srt_slurm/prepare_srt_power helpers and the USES_GLM52_RECOVERY branch in launch_b200-nscale-slurm.sh against the repo's bash conventions (no set -u, check_env_vars used for required inputs, no unconditional-default overrides replacing caller-supplied CONFIG_FILE/SRTCTL_RECIPE_ARGS) and found no violations. Because this touches Slurm launcher branching and a new native power-telemetry validation path, a human look is still worthwhile.
Extended reasoning...
The diff adds a new PowerX telemetry-validation path (inspect_power in infx/srt_slurm/synthetic_acceptance.py), new bash helpers (install_srt_slurm, prepare_srt_power, srt_slurm_version) in runners/slurm_utils.sh, and a new USES_GLM52_RECOVERY branch in runners/launch_b200-nscale-slurm.sh, plus recipe/config changes (agg/disagg-variants.yaml, power-counters.csv) and a vendored patch file. No auth/crypto surface; the sensitive surface is override/precedence correctness for a Slurm job launcher and schema validation via SrtConfig. I independently verified override-argument consistency between inspect_power and plan_commands and checked the new bash code against the repo's mandatory bash conventions (no nounset, check_env_vars usage, no silent defaults), finding nothing beyond the two already-ruled-out candidates, which is why I deferred with a short note rather than approving outright given the change's size and launcher-critical nature.
This review covers commit b3155e8, which is no longer the latest commit on this pull request; later commits are not covered by it.
|
Sorry, over the weekend, there was 2 major refactors to clean up the technical debt accumalated over the past 11 months of moving at the speed of light. We don't see any major refactors in the forthseeable future besides cleaning up AMD multinode AgentX pile of bash. As much, due to the refactors, u would need to ask your agent to rebase from remote main@latest. Thank you in advance for ur understanding |
|
Merging origin/main in (the repo's merge-from-main flow, not a rebase, so run 36304573738 stays pinnable) as soon as its last job, 1P×4D c48, finishes — pushing now would cancel that sweep. The merge is already prepared locally; only conflict is the perf-changelog tail after #3525. Generated by Claude Code |
|
/use 36304573738 Generated by Claude Code |
|
/use 36304573738 |
将 main 合并进本分支以跟上 #3525 等重构;仅解决 perf-changelog.yaml 尾部冲突, 配方改动与基准矩阵不变,保留 5348346 以复用已 /use 的 sweep 36304573738。 Co-Authored-By: Claude Fable 5.1 <[email protected]> Claude-Session: https://claude.ai/code/session_01FvrigUBZgG9bcFtWHPccAU
再次合并 main 以保持可合并状态;仅解决 perf-changelog.yaml 尾部冲突, 配方与基准矩阵不变,保留 5348346 以复用已 /use 的 sweep 36304573738。 Co-Authored-By: Claude Fable 5.1 <[email protected]> Claude-Session: https://claude.ai/code/session_01FvrigUBZgG9bcFtWHPccAU
再次合并 main 以保持可合并状态;仅解决 perf-changelog.yaml 尾部冲突, 配方与基准矩阵不变,保留 5348346 以复用已 /use 的 sweep 36304573738。 Co-Authored-By: Claude Fable 5.1 <[email protected]> Claude-Session: https://claude.ai/code/session_01FvrigUBZgG9bcFtWHPccAU
再次合并 main 以保持可合并状态;仅解决 perf-changelog.yaml 尾部冲突, 配方与基准矩阵不变,保留 5348346 以复用已 /use 的 sweep 36304573738。 Co-Authored-By: Claude Fable 5.1 <[email protected]> Claude-Session: https://claude.ai/code/session_01FvrigUBZgG9bcFtWHPccAU
再次合并 main 以保持可合并状态;仅解决 perf-changelog.yaml 尾部冲突, 配方与基准矩阵不变,保留 5348346 以复用已 /use 的 sweep 36304573738。 Co-Authored-By: Claude Fable 5.1 <[email protected]> Claude-Session: https://claude.ai/code/session_01FvrigUBZgG9bcFtWHPccAU
再次合并 main 以保持可合并状态;仅解决 perf-changelog.yaml 尾部冲突, 配方与基准矩阵不变,保留 5348346 以复用已 /use 的 sweep 36304573738。 Co-Authored-By: Claude Fable 5.1 <[email protected]> Claude-Session: https://claude.ai/code/session_01FvrigUBZgG9bcFtWHPccAU
再次合并 main 以保持可合并状态;仅解决 perf-changelog.yaml 尾部冲突, 配方与基准矩阵不变,保留 5348346 以复用已 /use 的 sweep 36304573738。 Co-Authored-By: Claude Fable 5.1 <[email protected]> Claude-Session: https://claude.ai/code/session_01FvrigUBZgG9bcFtWHPccAU
再次合并 main 以保持可合并状态;仅解决 perf-changelog.yaml 尾部冲突, 配方与基准矩阵不变,保留 5348346 以复用已 /use 的 sweep 36304573738。 Co-Authored-By: Claude Fable 5.1 <[email protected]> Claude-Session: https://claude.ai/code/session_01FvrigUBZgG9bcFtWHPccAU
再次合并 main 以保持可合并状态;仅解决 perf-changelog.yaml 尾部冲突, 配方与基准矩阵不变,保留 5348346 以复用已 /use 的 sweep 36304573738。 Co-Authored-By: Claude Fable 5.1 <[email protected]> Claude-Session: https://claude.ai/code/session_01FvrigUBZgG9bcFtWHPccAU
Description
Set
SGLANG_NVFP4_CKPT_FP8_NEXTN_MOE=0in the GLM-5.2 B200 AgentX recipes so the NextN/MTP draft MoE keeps its shipped precision, per the draft-precision rule. Images, topology and workload are unchanged.Testing: Full sweep (attempt 4) green: 5/5 AgentX points; GSM8K strict 0.966 (C48) and 0.965 (C64).
中文
在 GLM-5.2 B200 AgentX 配方中设置
SGLANG_NVFP4_CKPT_FP8_NEXTN_MOE=0,按 draft 精度规则让 NextN/MTP draft MoE 保持原始发布精度。镜像、拓扑和工作负载不变。测试: 完整 sweep(第 4 次尝试)全绿:5/5 个 AgentX 点;GSM8K strict 0.966(C48)和 0.965(C64)。
AI model disclosure
claude-opus-5-5).Related Issue
Related to #3228. / 关联 #3228。
Type of Change
Checklist
perf-changelog.yamland have not edited historical entriesOWNER/MEMBER/COLLABORATOR) has commented/use <run_id>(or the legacy/reuse-sweep-run) on this PR. Do this only once there is a final full sweep that is all green with evals passing, since after this comment the sweep label will no longer automatically kick off new sweeps. Remove and re-add the label to force one.