Skip to content

[PowerX] remove unavailable estimate lists / 移除无法估算配置列表 - #1249

Merged
edwingao28 merged 1 commit into
feat/powerx-nvl72-smart-provisioningfrom
fix/remove-profit-unavailable-list
Oct 1, 2026
Merged

edwingao28 merged 1 commit into
feat/powerx-nvl72-smart-provisioningfrom
fix/remove-profit-unavailable-list

Conversation

@edwingao28

@edwingao28 edwingao28 commented Oct 1, 2026 •

Copy link
Copy Markdown
Collaborator

Summary

Remove repetitive unavailable-estimate lists from profit charts. Keep the existing empty state, calculations and API skip reasons.

Depends on #1190.

AI model disclosure

  • Model/version: GPT-6; exact variant unverified.
  • Role: implementation and verification.

Validation

App unit suite and 59 profit browser tests pass; EN desktop/ZH mobile inspected. Three unchanged database tests time out locally. Smoke checks pass.

  • I have completed the AI model disclosure and kept it current

中文说明

移除利润图中重复的无法估算配置列表,保留现有空状态、计算结果和 API 跳过原因。依赖 #1190。

GPT-6 负责实现和验证,精确变体无法核实。应用单元测试及 59 项利润页面浏览器测试通过,已检查英文桌面和中文手机布局。三个未改动的数据库测试在本地超时;冒烟检查通过。


Note

Low Risk
Presentation-only UI and documentation changes; profit estimation, API skip reasons, and CSV exports are explicitly unchanged.

Overview
Removes the profit estimator’s Unavailable estimates disclosure and related copy so charts no longer list per-SKU skip reasons (unpriced vs missing measured/modeled power).

ProfitEstimatorDisplay drops the profit-power-unavailable <details> block, the empty-state paragraph that repeated those lists, the powerUnavailable memo, and EN/ZH strings for skip reasons and section titles. Power basis notes, NVL72 notes, CSV power columns, and pricing math are unchanged.

Docs (dashboard read-only views, PowerX EN/ZH, TCO calculator) now state that omission is presentation-only: the API still returns skipped rows and reasons; Compare both behavior and calculations are the same. User flows no longer tell readers to expand Unavailable estimates.

Cypress expects profit-power-unavailable absent, uses new screenshot names, and when measured power prices nothing asserts the existing No SKU can be priced for the current selection. empty state instead of the old list.

Reviewed by Cursor Bugbot for commit 916ddbb. Bugbot is set up for automated code reviews on this repo. Configure here.

中文:移除无法估算配置列表。
@edwingao28
edwingao28 requested a review from adibarra as a code owner October 1, 2026 20:47
@vercel

vercel Bot commented Oct 1, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
inferencemax-app Ready Ready Preview Oct 1, 2026 8:49pm UTC

Request Review

@github-actions

github-actions Bot commented Oct 1, 2026 •

Copy link
Copy Markdown
Contributor

Claude finished @edwingao28's task in 2m 48s —— View job


Review: PR #1249 — remove unavailable estimate lists

🟢 LGTM — no blocking issues found.

This is a clean deletion PR. I reviewed the diff statically and verified the changed behavior at runtime.

What I checked:

  • Clean removal — the unavailableEstimates/skipped/modeledUnavailable/skipReason strings, the powerUnavailable memo, both data-testid="profit-power-unavailable" render blocks, the dead memo dep entries, and the ProfitEstimatorSkipReason display import are all removed together with no dangling references. ProfitEstimatorSkipReason is still correctly used by the calculation layer (profit-estimator.ts, profit-power.ts), so API skip reasons are preserved as the PR intends.
  • Empty state retained — when no SKU can be priced, ProfitEstimatorChart still renders its own noData message ("No SKU can be priced for the current selection." / "当前选择下没有可定价的 SKU。"), which the updated Cypress case now asserts.
  • Tests — profit-estimator.cy.ts is updated to assert the list no longer exists across all affected cases, including the all-unavailable path. No new product code was added, so no new unit tests are required.
  • Docs — EN and ZH (powerx-system-power.md/.zh.md, dashboard-readonly-views.md, tco-calculator.md) are updated consistently and read naturally; no new user-visible Chinese UI strings were introduced.
  • Runtime — loaded /profit-estimator-per-gigawatt; chart renders real data with bars/margins and no unavailable-estimate list below it. 0 console errors (only an unrelated pre-existing SVG-preload warning).

Minor (non-blocking): estimate.skipped (line ~1083) is now carried in the memo object but no longer consumed by the display — harmless dead field, safe to drop later if you touch this.

Note on CI: The dedicated tests-unit/tests-e2e/lint workflows had not reported at review time (Vercel passed). None are failing; please confirm they go green before merge.

  • Gather context
  • Analyze code changes
  • Check CI status
  • Runtime verification
  • Post review

@edwingao28
edwingao28 merged commit 9a62745 into feat/powerx-nvl72-smart-provisioning Oct 1, 2026
7 checks passed
@edwingao28
edwingao28 deleted the fix/remove-profit-unavailable-list branch October 1, 2026 21:17

This branch was successfully deployed

1 active deployment
Preview — 916ddbbb Deployed Oct 1, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant