[PowerX] remove unavailable estimate lists / 移除无法估算配置列表 - #1249
Merged
edwingao28 merged 1 commit intoOct 1, 2026
Merged
edwingao28 merged 1 commit into
edwingao28 merged 1 commit into
Conversation
中文:移除无法估算配置列表。
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Claude finished @edwingao28's task in 2m 48s —— View job Review: PR #1249 — remove unavailable estimate lists🟢 LGTM — no blocking issues found. This is a clean deletion PR. I reviewed the diff statically and verified the changed behavior at runtime. What I checked:
Minor (non-blocking): Note on CI: The dedicated
|
edwingao28
merged commit Oct 1, 2026
9a62745
into
feat/powerx-nvl72-smart-provisioning
7 checks passed
1 task done
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove repetitive unavailable-estimate lists from profit charts. Keep the existing empty state, calculations and API skip reasons.
Depends on #1190.
AI model disclosure
Validation
App unit suite and 59 profit browser tests pass; EN desktop/ZH mobile inspected. Three unchanged database tests time out locally. Smoke checks pass.
中文说明
移除利润图中重复的无法估算配置列表,保留现有空状态、计算结果和 API 跳过原因。依赖 #1190。
GPT-6 负责实现和验证,精确变体无法核实。应用单元测试及 59 项利润页面浏览器测试通过,已检查英文桌面和中文手机布局。三个未改动的数据库测试在本地超时;冒烟检查通过。
Note
Low Risk
Presentation-only UI and documentation changes; profit estimation, API skip reasons, and CSV exports are explicitly unchanged.
Overview
Removes the profit estimator’s Unavailable estimates disclosure and related copy so charts no longer list per-SKU skip reasons (unpriced vs missing measured/modeled power).
ProfitEstimatorDisplaydrops theprofit-power-unavailable<details>block, the empty-state paragraph that repeated those lists, thepowerUnavailablememo, and EN/ZH strings for skip reasons and section titles. Power basis notes, NVL72 notes, CSV power columns, and pricing math are unchanged.Docs (dashboard read-only views, PowerX EN/ZH, TCO calculator) now state that omission is presentation-only: the API still returns skipped rows and reasons; Compare both behavior and calculations are the same. User flows no longer tell readers to expand Unavailable estimates.
Cypress expects
profit-power-unavailableabsent, uses new screenshot names, and when measured power prices nothing asserts the existing No SKU can be priced for the current selection. empty state instead of the old list.Reviewed by Cursor Bugbot for commit 916ddbb. Bugbot is set up for automated code reviews on this repo. Configure here.