Repository navigation
fix: 62处代码审查修复(OCR全量审查+增量复核) - #1
Merged
Merged
Conversation
两轮 ocr scan(glm-5.2)发现的问题逐条修复,测试全程 543 passed/1 skipped。 第一轮(48处): - A类机械修复:EOFError守卫、类型守卫、HTML转义、跨平台os.startfile→QDesktopServices、frozenset等 - B类中风险:cancel watcher异常守卫、lifecycle order强制、scheduler孤儿future取消、selection未知模式raise、executors进程组kill父子pgid守卫(critical清零)、timeout=0语义、process_runner统一安全默认、run_worker重入守卫、run_dispatch stop失败abort+竞态窗消除 - C类系统性:panel批量删除单session事务、database_runs TOCTOU改原子UPDATE、Secret脱敏补全 第二轮(14处): - 新发现high修复:log_panel/run_history跨平台、webhook mask防userinfo泄漏、blockSignals try/finally、QTimer singleShot、create_stage None guard、deleteChar多删一行、executable禁止守卫、rmtree记日志、version严格类型检查 - 误报回退3条 测试更新: - test_process_runner:断言stdin=DEVNULL安全默认注入 - test_ui_batch_ops:断言单session事务行为 broad-except baseline登记2项 hotspot baseline更新49项
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
两轮 ocr scan(glm-5.2)发现的问题逐条修复,测试全程 543 passed/1 skipped。
第一轮(48处)
第二轮(14处)
测试更新
Baseline 更新