Skip to content

fix: 62处代码审查修复(OCR全量审查+增量复核) - #1

Merged
Seller-1990 merged 1 commit into
mainfrom
fix/ocr-code-review-batch
Sep 19, 2026
Merged

Seller-1990 merged 1 commit into
mainfrom
fix/ocr-code-review-batch

Conversation

@Seller-1990

Copy link
Copy Markdown
Owner

两轮 ocr scan(glm-5.2)发现的问题逐条修复,测试全程 543 passed/1 skipped。

第一轮(48处)

  • A类机械修复:EOFError守卫、类型守卫、HTML转义、跨平台 os.startfile→QDesktopServices、frozenset 等
  • B类中风险:cancel watcher 异常守卫、lifecycle order 强制、scheduler 孤儿 future 取消、selection 未知模式 raise、executors 进程组 kill 父子 pgid 守卫(critical 清零)、timeout=0 语义、process_runner 统一安全默认、run_worker 重入守卫、run_dispatch stop 失败 abort + 竞态窗消除
  • C类系统性:panel 批量删除单 session 事务、database_runs TOCTOU 改原子 UPDATE、Secret 脱敏补全

第二轮(14处)

  • log_panel/run_history 跨平台、webhook mask 防 userinfo 泄漏、blockSignals try/finally、QTimer singleShot、create_stage None guard、deleteChar 多删一行、executable 禁止守卫、rmtree 记日志、version 严格类型检查

测试更新

  • test_process_runner:断言 stdin=DEVNULL 安全默认注入
  • test_ui_batch_ops:断言单 session 事务行为

Baseline 更新

  • broad-except baseline 登记 2 项
  • hotspot baseline 更新 49 项

两轮 ocr scan(glm-5.2)发现的问题逐条修复,测试全程 543 passed/1 skipped。

第一轮(48处):
- A类机械修复:EOFError守卫、类型守卫、HTML转义、跨平台os.startfile→QDesktopServices、frozenset等
- B类中风险:cancel watcher异常守卫、lifecycle order强制、scheduler孤儿future取消、selection未知模式raise、executors进程组kill父子pgid守卫(critical清零)、timeout=0语义、process_runner统一安全默认、run_worker重入守卫、run_dispatch stop失败abort+竞态窗消除
- C类系统性:panel批量删除单session事务、database_runs TOCTOU改原子UPDATE、Secret脱敏补全

第二轮(14处):
- 新发现high修复:log_panel/run_history跨平台、webhook mask防userinfo泄漏、blockSignals try/finally、QTimer singleShot、create_stage None guard、deleteChar多删一行、executable禁止守卫、rmtree记日志、version严格类型检查
- 误报回退3条

测试更新:
- test_process_runner:断言stdin=DEVNULL安全默认注入
- test_ui_batch_ops:断言单session事务行为

broad-except baseline登记2项
hotspot baseline更新49项
@Seller-1990
Seller-1990 merged commit 4d574a3 into main Sep 19, 2026
1 check passed
@Seller-1990
Seller-1990 deleted the fix/ocr-code-review-batch branch September 19, 2026 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant