Repository navigation
feat: integra health check, Snyk y SonarCloud - #7
Merged
Merged
Conversation
Valida configuracion, artefactos locales y acceso a S3. Se integra en CI (solo config) y en el entrenamiento (artefactos + S3) con cobertura pytest.
Agrega workflow con Snyk Open Source, Snyk Code y SonarCloud, incluyendo cobertura y subida de SARIF a GitHub Security.
Documenta el CLI de health, Snyk, SonarCloud, secretos, cobertura y corrige enlaces y descripcion desactualizada de CI.
Agrega ExpectedBucketOwner en las llamadas a S3 para verificar la propiedad del bucket y suma tests para S3, salida de texto y modo estricto.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Resumen
ml/health.py, un CLI de health check que valida configuracion, artefactos locales y acceso a S3.security.ymlcon Snyk Open Source, Snyk Code y SonarCloud.sonar-project.propertiesy cobertura conpytest-cov.ExpectedBucketOwner(hallazgo corregido de Sonar).Verificacion local
ruff check ml tests-> OKpytest tests/ -v --cov=ml --cov-report=term-missing-> 31 passed,ml/health.py95% coberturapython -m ml.health --json --skip-s3 --skip-artifacts->status: okpython -m ml.health --json --skip-s3->status: degradedpor artefactos locales ausentes (esperado en checkout limpio)Checks de CI
Secrets y variables
SNYK_TOKEN,SONAR_TOKENSONAR_ORGANIZATION=sebithaz-dev,SONAR_PROJECT_KEY=Sebithaz-dev_Model-Training-S3Notas
continue-on-error); los hallazgos se suben como SARIF a GitHub Security.