Add full unit test suite, CI for GitHub Actions and GitLab, and two crash fixes (2.5, 2.7)

[SeanathanVT]

Summary

Implements ROADMAP 2.5 (Unit Tests) and 2.7 (Continuous Integration). Writing the tests turned up two app.py bugs, which this PR also fixes, and a front-end bug that is logged as ROADMAP 3.18 for a follow-up.

• 314 tests, 98.4% line+branch coverage (98.5% line-only). They run in about a second and pass on Python 3.10, 3.12 and 3.13.
• CI on GitHub Actions and GitLab CI, running ruff and pytest with a coverage report.
• No behavior change for normal use apart from the two fixes below.

Fixes

• Pause and speed buttons returned a 500 when the BLE loop was gone. /pause, the steppers and the presets called asyncio.run_coroutine_threadsafe without the try/except that /start and /resume already had. With no loop running they returned a server error, and /pause had already changed session state by then. They now log the error and redirect.
• A non-UTF-8 session_state.json crashed startup. _load_session_state() caught JSONDecodeError but not UnicodeDecodeError. It now catches ValueError, which covers both.

Tests

tests/conftest.py adds two shared fixtures:

• app_state: resets every app.py global, points the session-state file, config.json and the database at tmp_path, and records BLE coroutines instead of scheduling them.
• walking: a session in progress with a controllable clock, moved here from test_active_time.py.

File	Covers
test_app_helpers.py	Formatting, calories, settings casts/clamps, shortcut URLs, the stats/SSE payload, session-state save/load/clear (including corrupt files), config.json writes, DB helpers, and "log and continue" when storage fails
test_status_packet.py	Distance/step accumulation across device counter resets, calories, speed-history filtering and cap, resume speed on auto-pause, liveness stamping
test_routes.py	Every Flask route through the test client, including restore/discard, CSV export, settings save, /stats_stream and /shutdown
test_ble_async.py	Wake/start/stop sequences against a fake controller, light wake, lock timeouts, stats monitor, idle watchdog, disconnect handling, auto-reconnect backoff, scan/connect, the BLE thread lifecycle, signal shutdown
test_run.py	run.py's browser launch, HTTP shutdown call, and main()'s Waitress subprocess and Ctrl+C handling
test_port_check.py	Adds the EACCES/other bind-error hints

The tests never touch the real config.json, walkingdad.db or session_state.json.

Verification:

• Breaking six pieces of logic one at a time (the counter reset, the pause guard, the UTF-8 fix, the resume-speed choice, the max-speed clamp, the wake order) turned at least one test red each time.
• The suite stays green in random order, with each file run on its own, and with -W error::RuntimeWarning.

CI

• .github/workflows/ci.yml: ubuntu-latest, Python 3.10 (the supported floor) and 3.13. Runs on pull requests and on pushes to main/development.
• .gitlab-ci.yml: python:3.12. Uses merge-request pipelines when an MR is open and branch pipelines otherwise, and shows the coverage percentage plus a Cobertura report in the MR.
• Steps for both: pip install -r requirements.txt -r requirements-dev.txt, then ruff check ., then python -m pytest --cov=.. Coverage is reported but never fails the build.

Supporting changes

• Startup handlers: the SIGINT/SIGTERM handlers and the atexit hook are now installed only when startup is enabled (WALKINGDAD_NO_STARTUP not set). Before, importing app.py in tests installed them, and Ctrl+C killed pytest two seconds later.
• run.py: the launcher code moved into main() so it can be tested; python run.py works the same.
• Speed buttons: decrease_speed/increase_speed now reuse _set_preset_speed, so the guard and try/except live in one place.
• Lint: ruff==0.16.10 is pinned in requirements-dev.txt, because its default rule set changes between releases. ruff.toml ignores four rules that only flag deliberate project style: the root logger, catch-all excepts around BLE I/O, naive local datetimes, and one ValueError raised to share an except.
  • Lint fixes in app.py: sorted imports, unused global declarations removed, one nested if combined, IOError replaced by OSError, and dict literals. None change behavior.
• Config files: pytest.ini (pythonpath = ., so bare pytest works), .coveragerc (leaves tests out of coverage), and .gitignore additions for coverage output.

Docs

• ROADMAP:
  • 2.5 and 2.7 marked complete;
  • cross-references updated in 2.11, 2.12, 2.13 and 3.17;
  • new 3.18 Transition Hint Shows on Every Button Press. disableButtonsOnSubmit() shows each page's transition hint on every form submit, so for example clicking a speed preset flashes "Getting the belt moving…" and shifts the layout. It predates this branch; the fix is deferred to its own branch.
• README: the "Running tests" line now covers coverage, ruff and CI.
• CHANGELOG: [Unreleased] has Fixed and Internal entries. Released sections are unchanged.

Test plan

• ruff check . is clean
• python -m pytest passes on Python 3.10, 3.12 and 3.13
• CI commands run in a fresh venv; the GitLab coverage regex matches the TOTAL line
• actionlint passes on the GitHub workflow
• GitHub Actions passes on this PR
• Smoke test on real hardware (macOS): launch, Start, speed changes, Pause/Resume/End, Ctrl+C mid-session (belt stops, UI shows the shutdown notice), relaunch with no stray restore prompt

🤖 Generated with Claude Code