Repository navigation
feat(simulation): bind Hub models at runtime #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
问题 (bug_risk):
set_asset接受任意非空的命名空间、名称和可选版本,并在未查询或验证 Hub 模型的情况下将其作为simulation_asset发出,因此任意或不存在的身份都会被客户端当作已验证的 Hub 绑定。触发条件: 客户端发送了语法有效但不存在、未发布或未经验证的 Hub 身份时。
建议修复: 在修改状态之前,通过 Hub 验证/目录边界解析该引用;或者将此操作重命名并记录为接受未经验证的身份。
Original comment in English
issue (bug_risk):
set_assetaccepts any non-empty namespace, name, and optional version and emits it assimulation_assetwithout consulting or verifying a Hub model, so arbitrary or nonexistent identities are presented to clients as verified Hub bindings.Triggers: When a client sends a syntactically valid but nonexistent, unpublished, or unverified Hub identity.
Suggested fix: Resolve the reference through the Hub verification/catalog boundary before mutating state, or rename/document the action as accepting an unverified identity.