Sasdata database redux - #213
Merged
Merged
Conversation
…ailures on windows
…w-database branch
krzywon
marked this pull request as ready for review
June 4, 2026 13:49
Closed
DrPaulSharp
approved these changes
Jul 24, 2026
Collaborator
Author
|
Failing unit tests after a merge... I'll fix these shortly. |
![codescene-delta-analysis[bot]](https://avatars.githubusercontent.com/in/53921?s=60&v=4){kind=small}
There was a problem hiding this comment.
No quality gates enabled for this code.
See analysis details in CodeScene
Quality Gate Profile: Custom Configuration
Install CodeScene MCP: safeguard and uplift AI-generated code. Catch issues early with our IDE extension and CLI tool.
Collaborator
Author
|
The unit tests failing here are already failing in the refactor branch. The new, django-based tests all pass here. I think this is ready to merge. |
Contributor
|
The failed tests are also fixed in #220 (I can put a small PR in if there's a need to sort them sooner), so I'm happy to merge too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a recreation of the work done by @summerhenson in #106. The rebase and force-push commits into that branch caused issues that weren't easily recoverable. This now is the ground truth of the original PR, and all of the original changes are included without the massive changes to the base refactor_24 branch.
Sequence of operations to arrive here:
refactor_24into this branch, resolve conflicts, and resolve ruff issuesrefactor_24into this branch and resolve conflicts again, which brought the status closer to the PR changes