Skip to content

feat: Add Development Container and Windows specific development pre-requisites#5894

Open
davem-bis wants to merge 5 commits into
SQLMesh:mainfrom
davem-bis:feature/DRM/add-dev-container
Open

feat: Add Development Container and Windows specific development pre-requisites#5894
davem-bis wants to merge 5 commits into
SQLMesh:mainfrom
davem-bis:feature/DRM/add-dev-container

Conversation

@davem-bis

Copy link
Copy Markdown
Contributor

Description

Adds a development container for those working on Windows as the repository relies on Python functionality only available on UNIX systems.

Expands the development.md documentation to include caveats with developing on Windows.

Test Plan

Dev container was built from scratch and make fast-test run successfully.

Checklist

  • I have run make style and fixed any issues
  • [ ] I have added tests for my changes (if applicable) Not Applicable
  • All existing tests pass (make fast-test)
  • My commits are signed off (git commit -s) per the DCO

@StuffbyYuki

Copy link
Copy Markdown
Collaborator

@davem-bis Thanks for this PR!

Blocker

  • post-create-command.sh installs msodbcsql18 without adding the Microsoft apt repo. That package isn’t in Ubuntu’s default repos (see .circleci/install-prerequisites.sh fabric path), so a clean create should fail here. Easiest fix: drop msodbcsql18 from the default install (it’s only needed for Fabric/ODBC), or you can also restore the Microsoft repo setup.

Optional

  • Add set -e so apt failures don’t continue into make install-dev.
  • Docs: how to open the container, and that Windows host clones need core.symlinks=true before bind-mount.
  • Soften the SIGUSR1 rationale, that path is already gated via hasattr(faulthandler, "register"); symlinks are the clearer Windows caveat.

Let me know if I'm missing anything!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants