Name the scoped entity in the admin weekly bookings grid (#133) - #138
Merged
Merged
Conversation
The weekly grid labelled each row with the owning body's name, so a division-wide booking read as a booking for its primary body. It now uses formatScopeLabel, like the rest of the admin UI: a divisional booking shows its division, and a multi-body booking shows its owner plus the count of the others. Co-Authored-By: Claude Opus 5 <[email protected]>
pataniaeli
added
bug
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #133
What changed
In the admin weekly bookings grid, each row was labelled with
bodies.name, the owning body. So a division-wide booking showed as a booking for its primary body.The row label now uses
formatScopeLabel, the same helperScopeLabeluses elsewhere in the admin UI:Campus Affairs (Division) — 6:00 PMOwner + 2 others — 6:00 PMThe admin bookings route already returns
scope,divisionandbooking_bodies, so no API change was needed.Related, not changed here
A few other admin views still render
bodies?.namedirectly: the Cancellations tab card title, the Events page, and the Archive tab. They may have the same issue for divisional bookings. I kept this PR to the view the issue names.Testing
tsc --noEmitandeslintclean.🤖 Generated with Claude Code