Skip to content

Let a whole weekly SGA Space booking change space (#127) - #134

Merged
pataniaeli merged 2 commits into
devfrom
fix/issue-127-series-space-change
Sep 18, 2026
Merged

pataniaeli merged 2 commits into
devfrom
fix/issue-127-series-space-change

Conversation

@pataniaeli

Copy link
Copy Markdown
Collaborator

Closes #127

What changed

Editing Whole series on a weekly SGA Space booking now shows the Location selector, so a recurring meeting can follow a room change without being cancelled and rebooked.

  • The series PATCH accepts space_id (omitted = stays put; an unknown space is refused).
  • Every upcoming week is planned against the new space. A week in a different space claims all of its time there, so overlap, blackouts and advance notice apply — the same rule already used for a week that had been moved on its own.
  • Weeks that can't move are reported in the existing conflict panel and, on Save the rest, keep their current time and space. The update email names the space for any week not in the series' space.
  • The series row stores the new space, so weeks added by extending the end date are created there.
  • The "booked at the time you picked" markers are left off for series edits, since they describe a single slot.

Testing

  • tsc --noEmit and eslint clean.
  • Not exercised in a browser: the app requires a signed-in session.

🤖 Generated with Claude Code

Editing the whole series now offers the Location selector. Every upcoming
week that can take the move goes to the new space, checked the way a week
moved on its own already was -- all of its time is newly claimed there, so
overlap, blackouts and advance notice apply. Weeks that can't move keep
their time and space and are listed, as with a time change, and the series
itself records the new space so weeks added by extending it land there too.

Co-Authored-By: Claude Opus 5 <[email protected]>
@pataniaeli pataniaeli added the bug Something isn't working label Sep 16, 2026
@vercel

vercel Bot commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
chambers Ready Ready Preview Sep 18, 2026 5:07pm UTC

Resolves the conflict #137 predicted: #132 (external attendees) and this
branch each added a field to the same series PATCH destructuring, week and
series updates, and the modal's series submit body. Both are kept --
space_id from #127 and external_attendees from #132. Every place this branch
moved the series onto the new spaceId is unchanged.

Co-Authored-By: Claude Opus 5 <[email protected]>
@pataniaeli
pataniaeli merged commit 6f96da5 into dev Sep 18, 2026
4 checks passed
@pataniaeli
pataniaeli deleted the fix/issue-127-series-space-change branch September 18, 2026 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Meeting spaces for recurring SGA Space bookings cannot be changed as a complete series

1 participant