Conversation
…ui-cleanup-5712-continued
…ately" This reverts commit f6271c1.
ApiTokenBrowse handled by new API Move where selection button is added (for most cases) Change name to ContainerSize, because that's what it is for Fix logic that straight up didn't work for JobBrowse
Fix sensitivity overwriting button Refactor row rendering code
Update packages
Restrict "All users"-actions
Fix heights for all screen sizes after last commit
…hown for fake folders Styling
DanThrane
left a comment
DanThrane
left a comment
There was a problem hiding this comment.
Mostly a few concerns, can you look into these? It might be that none of these are actually a problem, but I suspect at least the useCloudAPI one might cause some problems.
|
|
||
| const [state, dispatch] = useReducer(dataFetchReducer, { | ||
| loading: false, | ||
| loading: true, |
There was a problem hiding this comment.
I think this needs to depend on if callParametersInitial if noop is true or not. If it is true then we end up in a forever loading state that might not be cleared. I am not sure if this breaks anywhere in our UI today, I think we normally just send off a refetch right away, but it might break something down the line. Should also be an issue fix.
| window.setTimeout(() => { | ||
| dialogStore.addDialog(<> | ||
| {linkInfo.loading ? <Spinner /> : | ||
| linkInfo.error ? <div className={Container}> |
There was a problem hiding this comment.
This will never be hit since data is still null (and thus was filtered out on line 35).
| const useButton = browser.defaultButtonRenderer(opts.selection, ip); | ||
| if (useButton) row.stat3.append(useButton); | ||
| } else if (ip.status.boundTo.length === 1) { | ||
| browser.on("renderStat4", (ip, stat) => { |
There was a problem hiding this comment.
I haven't run the code, but is this the correct one? Based on the columns from line 103, I would assume that this should be renderStat2?
| [ContainerSize.LARGE]: renderLarge, | ||
| }; | ||
|
|
||
| function statFromContainerSize(row: ResourceBrowserRow, containerSize: ContainerSize): HTMLElement { |
There was a problem hiding this comment.
I am unsure about this code, I haven't read it too carefully, but I am surprised that this code isn't considering which columns are defined in the resource browser. I would have assumed that this depends on the column count.
2 participants
Fixes remaining under #5712