Skip to content

WireMod Closure Update for icaruscode develop #913

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gputnam wants to merge 33 commits into
base: develop
Choose a base branch
from
Open

WireMod Closure Update for icaruscode develop #913

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
33 commits
Select commit Hold shift + click to select a range
de23932
Add SBNCode and SBNAnaObj to packages required in top-level ICARUSCod…
jas1005 Jun 4, 2026
e3340a1
add WireMod in X vs theta_XW
hausnerh Jan 13, 2026
83fe398
add ratio file
hausnerh Jan 13, 2026
8c80649
reintroduce shifted Edep handling
hausnerh Jan 16, 2026
54edc06
use WireToChanROI module
hausnerh Jan 28, 2026
dce3565
drop dropables
hausnerh Jan 29, 2026
756d377
reorder some ops
hausnerh Feb 5, 2026
82d6df5
Better ratio file handling
hausnerh Mar 9, 2026
65986a4
Add handling for non-global x coordinate
hausnerh Mar 9, 2026
cdab233
Get an offset from the difference in the BackTracker and the Detector…
hausnerh Mar 30, 2026
be30da3
Add dummy scaling to WireModXXW
hausnerh Mar 31, 2026
9184342
Add fhicls
hausnerh May 7, 2026
8bae05d
add WireModifierXXW.fcl
hausnerh May 8, 2026
64136cd
give optional YZ correction to XXW modifications
hausnerh May 11, 2026
40ca7b3
Add optionality to TGraphs per plane
hausnerh May 13, 2026
1c28cc4
Add catch blocks for depositions without a TPC or Wire
gputnam Apr 1, 2026
03f6efb
Update wiremod fcls
gputnam May 26, 2026
6b3a77e
Update WireMod asserts to exceptions
gputnam May 26, 2026
4e8df53
Remove stale config.
gputnam May 26, 2026
7d3dd09
Update ratio .root files.
gputnam May 26, 2026
41cb4b1
Update WireModifierXXW to new WireModUtility interface.
gputnam May 29, 2026
2a03fa8
Fix fcl inherit path.
gputnam May 29, 2026
92216b8
Remove old WireMod fcl file.
gputnam Jun 2, 2026
e7207e2
Fix non-larcv Run 4 wiremod fcl file.
gputnam Jun 2, 2026
ffb1490
Addition of some WireMod diagnostic tools, addition of some flags (us…
francescopoppi Jun 30, 2026
3f2333d
Build fixes.
gputnam Jun 30, 2026
a659b0c
Change truth matching to use SimChannel's instead of SimEnergyDeposit's
gputnam Jul 1, 2026
238fa8e
Add thxw resolution check to Diagnostic module.
gputnam Jul 1, 2026
b94ccd2
Fix dummy hit finder config to match the nominal hit finder.
gputnam Jul 1, 2026
8be3387
Fix thXW calculation.
gputnam Jul 2, 2026
5a0b372
WireModHitDiagnostic: added some additional fields.
francescopoppi Jul 8, 2026
77cb056
Now the fixes to achieve closure are propagated to the production fcls
francescopoppi Jul 8, 2026
44f7534
this fixes corrects an issue with loss of precision in conversion fro…
francescopoppi Jul 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,8 @@ find_package(ifdh_art REQUIRED )
find_package(Range-v3 REQUIRED )
find_package(sbnalg REQUIRED )
find_package(sbnobj REQUIRED )
find_package(sbnanaobj REQUIRED )
find_package(sbncode REQUIRED)
find_package(icarus_signal_processing REQUIRED )
find_package(icarusalg REQUIRED )
find_package(icarusutil REQUIRED )
Expand Down
1 change: 1 addition & 0 deletions icaruscode/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,4 +15,5 @@ add_subdirectory(RecoUtils)
add_subdirectory(TPC)
add_subdirectory(Utilities)
add_subdirectory(Overlays)
add_subdirectory(WireMod)
#add_subdirectory(Supera)
312 changes: 312 additions & 0 deletions icaruscode/WireMod/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,312 @@
set(EXCLUDED_PLUGINS WireModMakeHists_plugin.cc ROICounter_module.cc HitComp_plugin.cc HitTTreeMaker_plugin.cc WireModifier_module.cc WireModifierXXW_module.cc WireModHitDiagnostic_module.cc WireModScaleDebug_module.cc)

art_make(
LIB_LIBRARIES
${ART_FRAMEWORK_CORE}
art_Utilities canvas
${MF_MESSAGELOGGER}

cetlib cetlib_except
${Boost_SYSTEM_LIBRARY}
${ROOT_BASIC_LIB_LIST}
${ROOT_HIST}
MODULE_LIBRARIES
art_root_io::TFileService_service
lardataobj::AnalysisBase
lardataobj::RawData
lardataobj::RecoBase
lardata::RecoObjects
larreco::RecoAlg
lardata::Utilities
${LARRECO_LIB}
${LARDATA_LIB}
${ART_FRAMEWORK_CORE}
${ART_FRAMEWORK_PRINCIPAL}
${ART_FRAMEWORK_SERVICES_REGISTRY}
${ART_FRAMEWORK_SERVICES_OPTIONAL}
${ART_FRAMEWORK_SERVICES_OPTIONAL_RANDOMNUMBERGENERATOR_SERVICE}
${ART_FRAMEWORK_SERVICES_OPTIONAL_TFILESERVICE_SERVICE}
${MF_MESSAGELOGGER}
${FHICLCPP}
${CLHEP}
${ROOT_GEOM}
${ROOT_XMLIO}
${ROOT_GDML}
${ROOT_BASIC_LIB_LIST}
${ROOT_HIST}
EXCLUDE ${EXCLUDED_PLUGINS}
#WireMod_Utilities.hh
#WireMod_Utilities.cc
)

find_library( sbncode::sbncode_WireMod_Utility_LIBRARY NAMES sbncode::sbncode_WireMod_Utility )

simple_plugin(WireModMakeHists "plugin"
${ART_FRAMEWORK_CORE}
${MF_MESSAGELOGGER}
${Boost_SYSTEM_LIBRARY}
${ROOT_BASIC_LIB_LIST}
${ROOT_HIST}
art_root_io::TFileService_service
lardataobj::AnalysisBase
lardataobj::RawData
lardataobj::RecoBase
lardata::RecoObjects
larreco::RecoAlg
${LARRECO_LIB}
${LARDATA_LIB}
${ART_FRAMEWORK_CORE}
${ART_FRAMEWORK_PRINCIPAL}
${ART_FRAMEWORK_SERVICES_REGISTRY}
${ART_FRAMEWORK_SERVICES_OPTIONAL}
${ART_FRAMEWORK_SERVICES_OPTIONAL_RANDOMNUMBERGENERATOR_SERVICE}
${ART_FRAMEWORK_SERVICES_OPTIONAL_TFILESERVICE_SERVICE}
${MF_MESSAGELOGGER}
${FHICLCPP}
${CLHEP}
${ROOT_GEOM}
${ROOT_XMLIO}
${ROOT_GDML}
${ROOT_BASIC_LIB_LIST}
${ROOT_HIST}
BASENAME_ONLY
)

simple_plugin(HitComp "plugin"
${ART_FRAMEWORK_CORE}
${MF_MESSAGELOGGER}
${Boost_SYSTEM_LIBRARY}
${ROOT_BASIC_LIB_LIST}
${ROOT_HIST}
art_root_io::TFileService_service
lardataobj::AnalysisBase
lardataobj::RawData
lardataobj::RecoBase
lardata::RecoObjects
larreco::RecoAlg
${LARRECO_LIB}
${LARDATA_LIB}
${ART_FRAMEWORK_CORE}
${ART_FRAMEWORK_PRINCIPAL}
${ART_FRAMEWORK_SERVICES_REGISTRY}
${ART_FRAMEWORK_SERVICES_OPTIONAL}
${ART_FRAMEWORK_SERVICES_OPTIONAL_RANDOMNUMBERGENERATOR_SERVICE}
${ART_FRAMEWORK_SERVICES_OPTIONAL_TFILESERVICE_SERVICE}
${MF_MESSAGELOGGER}
${FHICLCPP}
${CLHEP}
${ROOT_GEOM}
${ROOT_XMLIO}
${ROOT_GDML}
${ROOT_BASIC_LIB_LIST}
${ROOT_HIST}
BASENAME_ONLY
)

simple_plugin(HitTTreeMaker "plugin"
${ART_FRAMEWORK_CORE}
${MF_MESSAGELOGGER}
${Boost_SYSTEM_LIBRARY}
${ROOT_BASIC_LIB_LIST}
${ROOT_HIST}
art_root_io::TFileService_service
lardataobj::AnalysisBase
lardataobj::RawData
lardataobj::RecoBase
lardata::RecoObjects
larreco::RecoAlg
${LARRECO_LIB}
${LARDATA_LIB}
${ART_FRAMEWORK_CORE}
${ART_FRAMEWORK_PRINCIPAL}
${ART_FRAMEWORK_SERVICES_REGISTRY}
${ART_FRAMEWORK_SERVICES_OPTIONAL}
${ART_FRAMEWORK_SERVICES_OPTIONAL_RANDOMNUMBERGENERATOR_SERVICE}
${ART_FRAMEWORK_SERVICES_OPTIONAL_TFILESERVICE_SERVICE}
${MF_MESSAGELOGGER}
${FHICLCPP}
${CLHEP}
${ROOT_GEOM}
${ROOT_XMLIO}
${ROOT_GDML}
${ROOT_BASIC_LIB_LIST}
${ROOT_HIST}
BASENAME_ONLY
)

cet_build_plugin(ROICounter art::module
LIBRARIES
${ART_FRAMEWORK_CORE}
${MF_MESSAGELOGGER}
${Boost_SYSTEM_LIBRARY}
${ROOT_BASIC_LIB_LIST}
${ROOT_HIST}
art_root_io::TFileService_service
lardataobj::AnalysisBase
lardataobj::RawData
lardataobj::RecoBase
lardata::RecoObjects
larreco::RecoAlg
${LARRECO_LIB}
${LARDATA_LIB}
${ART_FRAMEWORK_CORE}
${ART_FRAMEWORK_PRINCIPAL}
${ART_FRAMEWORK_SERVICES_REGISTRY}
${ART_FRAMEWORK_SERVICES_OPTIONAL}
${ART_FRAMEWORK_SERVICES_OPTIONAL_RANDOMNUMBERGENERATOR_SERVICE}
${ART_FRAMEWORK_SERVICES_OPTIONAL_TFILESERVICE_SERVICE}
${MF_MESSAGELOGGER}
${FHICLCPP}
${CLHEP}
${ROOT_GEOM}
${ROOT_XMLIO}
${ROOT_GDML}
${ROOT_BASIC_LIB_LIST}
${ROOT_HIST}
)

simple_plugin(WireModifier "module"
${ART_FRAMEWORK_CORE}
${MF_MESSAGELOGGER}
${Boost_SYSTEM_LIBRARY}
${ROOT_BASIC_LIB_LIST}
${ROOT_HIST}
art_root_io::TFileService_service
lardataobj::AnalysisBase
lardataobj::RawData
lardataobj::RecoBase
lardata::RecoObjects
larreco::RecoAlg
${LARRECO_LIB}
${LARDATA_LIB}
${ART_FRAMEWORK_CORE}
${ART_FRAMEWORK_PRINCIPAL}
${ART_FRAMEWORK_SERVICES_REGISTRY}
${ART_FRAMEWORK_SERVICES_OPTIONAL}
${ART_FRAMEWORK_SERVICES_OPTIONAL_RANDOMNUMBERGENERATOR_SERVICE}
${ART_FRAMEWORK_SERVICES_OPTIONAL_TFILESERVICE_SERVICE}
${MF_MESSAGELOGGER}
${FHICLCPP}
${CLHEP}
${ROOT_GEOM}
${ROOT_XMLIO}
${ROOT_GDML}
${ROOT_BASIC_LIB_LIST}
${ROOT_HIST}
larcore::Geometry_Geometry_service
larcorealg::Geometry
lardataalg::DetectorInfo
lardata::Utilities
lardata::DetectorInfoServices_DetectorClocksServiceStandard_service
sbnobj::ICARUS_TPC
sbncode::WireMod_Utility
BASENAME_ONLY
)

simple_plugin(WireModifierXXW "module"
${ART_FRAMEWORK_CORE}
${MF_MESSAGELOGGER}
${Boost_SYSTEM_LIBRARY}
${ROOT_BASIC_LIB_LIST}
${ROOT_HIST}
art_root_io::TFileService_service
lardataobj::AnalysisBase
lardataobj::RawData
lardataobj::RecoBase
lardata::RecoObjects
larreco::RecoAlg
${LARRECO_LIB}
${LARDATA_LIB}
${ART_FRAMEWORK_CORE}
${ART_FRAMEWORK_PRINCIPAL}
${ART_FRAMEWORK_SERVICES_REGISTRY}
${ART_FRAMEWORK_SERVICES_OPTIONAL}
${ART_FRAMEWORK_SERVICES_OPTIONAL_RANDOMNUMBERGENERATOR_SERVICE}
${ART_FRAMEWORK_SERVICES_OPTIONAL_TFILESERVICE_SERVICE}
${MF_MESSAGELOGGER}
${FHICLCPP}
${CLHEP}
${ROOT_GEOM}
${ROOT_XMLIO}
${ROOT_GDML}
${ROOT_BASIC_LIB_LIST}
${ROOT_HIST}
larcore::Geometry_Geometry_service
larcorealg::Geometry
lardataalg::DetectorInfo
lardata::Utilities
lardata::DetectorInfoServices_DetectorClocksServiceStandard_service
sbnobj::ICARUS_TPC
sbncode::WireMod_Utility
BASENAME_ONLY
)

simple_plugin(WireModHitDiagnostic "module"
${ART_FRAMEWORK_CORE}
${MF_MESSAGELOGGER}
${Boost_SYSTEM_LIBRARY}
${ROOT_BASIC_LIB_LIST}
${ROOT_HIST}
art_root_io::TFileService_service
lardataobj::AnalysisBase
lardataobj::RawData
lardataobj::RecoBase
lardata::RecoObjects
larreco::RecoAlg
${LARRECO_LIB}
${LARDATA_LIB}
${ART_FRAMEWORK_CORE}
${ART_FRAMEWORK_PRINCIPAL}
${ART_FRAMEWORK_SERVICES_REGISTRY}
${ART_FRAMEWORK_SERVICES_OPTIONAL}
${ART_FRAMEWORK_SERVICES_OPTIONAL_RANDOMNUMBERGENERATOR_SERVICE}
${ART_FRAMEWORK_SERVICES_OPTIONAL_TFILESERVICE_SERVICE}
${MF_MESSAGELOGGER}
${FHICLCPP}
${CLHEP}
${ROOT_GEOM}
${ROOT_XMLIO}
${ROOT_GDML}
${ROOT_BASIC_LIB_LIST}
${ROOT_HIST}
BASENAME_ONLY
)

simple_plugin(WireModScaleDebug "module"
${ART_FRAMEWORK_CORE}
${MF_MESSAGELOGGER}
${Boost_SYSTEM_LIBRARY}
${ROOT_BASIC_LIB_LIST}
${ROOT_HIST}
art_root_io::TFileService_service
lardataobj::AnalysisBase
lardataobj::RawData
lardataobj::RecoBase
lardata::RecoObjects
larreco::RecoAlg
${LARRECO_LIB}
${LARDATA_LIB}
${ART_FRAMEWORK_CORE}
${ART_FRAMEWORK_PRINCIPAL}
${ART_FRAMEWORK_SERVICES_REGISTRY}
${ART_FRAMEWORK_SERVICES_OPTIONAL}
${ART_FRAMEWORK_SERVICES_OPTIONAL_RANDOMNUMBERGENERATOR_SERVICE}
${ART_FRAMEWORK_SERVICES_OPTIONAL_TFILESERVICE_SERVICE}
${MF_MESSAGELOGGER}
${FHICLCPP}
${CLHEP}
${ROOT_GEOM}
${ROOT_XMLIO}
${ROOT_GDML}
${ROOT_BASIC_LIB_LIST}
${ROOT_HIST}
larcore::Geometry_Geometry_service
larcorealg::Geometry
BASENAME_ONLY
)

install_headers()
install_fhicl()
install_source()
FILE(GLOB ratios *.root )
install(FILES ${ratios} DESTINATION root/WireMod)
10 changes: 10 additions & 0 deletions icaruscode/WireMod/HitComp.fcl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
BEGIN_PROLOG

standard_hitcomp:
{
plugin_type: "HitComp"
Label: "gaushit1dTPCEE"
Process: "MCstage0Var"
}

END_PROLOG
Loading