Repository navigation
icon buttons draw the hover label they already carry - #13
Merged
1 commit merged intoOct 21, 2026
Merged
1 commit merged into
1 commit merged into
Conversation
a1510fb
Member
|
Merged, thank you. |
aethctl
pushed a commit
to Ryoku-dev/RyotunesNix
that referenced
this pull request
Oct 26, 2026
…ey already carry
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
IconButtondeclaresproperty string tip: ""and never draws it. The component is a plate, anIcon, aHoverHandlerand aMouseArea, so everytip:written across the app sets a property nothing renders: Play/Pause/Next inNowPlayingCard, "Collapse" in theSidebar, "Save to library" and "More" inPageHero, "Remove from queue" inQueuePanel, "Close" inShortcutPicker, five inMiniPlayer. The labels are written and invisible.The title bar makes it worse: nine icon buttons,
tipon none of them. Account, Listen Together, Discord, the panel toggle, Sound and the mini window are bare glyphs. In the Ryoku Discord someone asked for the Discord toggle to be moved into settings "rather than a toggle not explaining to anybody what it does" (it is already in Settings > General > Discord, with a description, a live status line and a presence title; it was the title-bar icon that explained nothing).This draws the label on hover, in the same shape
DownloadButtonandWaveformalready use: one elided line onpaperLiftwith a hairline border, fading unlessTokens.reduceMotionis set.tipBelowputs it under the button for a row that sits against the top of the window, and the tip doubles asAccessible.name.The title bar's nine buttons get their labels. The Discord one reads its state, so the icon now says whether rich presence is on.
One stacking change comes with it:
TitleBargetsz: 10, because the page below is a later sibling in the column and painted over a label that hangs under the bar.What this does not fix
NowPlayingCardsetsclip: trueon its root, so the three transport labels it already carries are still clipped away. The clip looks deliberate (rounded card, artwork), so I left it alone rather than guess. The same may hold anywhere else an ancestor clips.Verified
Hovered on a running client built from this branch: the Discord button shows "Discord rich presence is on" under the bar, and the plate follows the setting. The transport buttons in
NowPlayingCardstill show nothing, which is the clip above, confirmed by the hover tint appearing on the shuffle button while no label does.