Repository navigation
fix: play on collection starts in sequence and active icon toggles show accent color - #12
Merged
1 commit merged intoOct 21, 2026
Merged
1 commit merged into
1 commit merged into
Conversation
a1510fb
Member
|
Merged, thank you. |
aethctl
pushed a commit
to Ryoku-dev/RyotunesNix
that referenced
this pull request
Oct 26, 2026
…quence and active icon toggles show accent color
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
IconButton.qml&MiniPlayer.qml: active icon color now usesStyle.accentinstead ofTokens.ink/Tokens.bone. Active controls (Shuffle, Repeat) now have clear visual contrast indicating when they are enabled, matching Svelte'stext-primaryand the heart/like button override inPlayerBar.qml.crates/core/src/state.rs(play_tracks) &methods.rs(play_playlist):shuffleargument is nowOption<bool>rather than defaulting tofalsewhen absent.Some(false), or when starting a collection without specifying a track or shuffle (shuffle.is_none() && start.is_none()),keep_shuffledis turned off andq.shuffle_origis reset toNone.Some(true), shuffle is enabled.Noneand a specific track was clicked (start.is_some()), existing queue shuffle state is preserved.PlaylistPage.qml,AlbumPage.qml,LibrarySongs.qml,MediaCard.qml: the primary "Play" button explicitly passesshuffle: start === null ? false : undefined.crates/core/src/state.rs:play_collection_defaults_to_sequential_unless_explicitly_shuffled.Why
Tokens.inkvsTokens.inkMuted. In Quickshell palettes, both are monochromatic shades with low contrast, making it virtually impossible to distinguish whether Shuffle or Repeat is turned on or off.q.shuffle_orig.is_some()persisted ("sticky across queues"), picking a random track (rand::Rng::gen_range) and shuffling the list. Since the playlist page provides a dedicated "Shuffle" button right next to "Play", clicking "Play" was expected to play sequentially from the beginning (track 1) and disable shuffle.Surface area
playback, PlayerBar, mini-player, PlaylistPage, AlbumPage, Library
Validation
./scripts/release-check.shcargo fmt --all -- --checkcargo test -p ryotunes-core -p ryotunesdall 142 tests pass)./scripts/check-release-invariants.py./scripts/check-source-shapes.py./scripts/check-rust-structure.pyStyle.accent, clicking "Play" on a playlist starts sequentially from track 1 and clears shuffle, clicking "Shuffle" shuffles the playlist, and clicking track fix: advance past Spotify tracks and make them seekable #3 with shuffle active starts at track fix: advance past Spotify tracks and make them seekable #3 and preserves shuffle for remaining tracks.Regression contracts
IconButton.qmlandMiniPlayer.qmluseStyle.accent, ensuring active toggles dynamically follow live system palette/theme switches.