Repository navigation
fix: prevent lost updates in concurrent persistence - #188
Closed
tuberkulez-takt wants to merge 1 commit into
Closed
tuberkulez-takt wants to merge 1 commit into
tuberkulez-takt wants to merge 1 commit into
Conversation
Fix concurrent read-modify-write races that can cause persisted project, settings, category, or workspace data to be overwritten by a concurrent writer.
Owner
|
please do disclose if you use AI assistance or Vibe coded. its not banned but its required to disclose it. and please do fix the conflicts. i did merged ur other two PRs for now |
Owner
|
Hi again, this PR will be closed if I receive no reply within 2 more days. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Blocking operations should be handled via
spawn_blocking, meaning the calls run in parallel on the Tokio pool.persist::write_json_with_backupuses a "write-to-temp-then-rename" strategy; this prevents corrupted JSON but does not protect against lost updates—where two parallel sequences ofread(old)followed bywrite(A)andwrite(B)result in the last write winning.https://docs.rs/tauri/latest/tauri/struct.State.html