Skip to content

Fix moveProjects leaving the UI and disk state inconsistent when a pr… #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RykoTheDev merged 1 commit into from
Sep 22, 2026
Merged

Fix moveProjects leaving the UI and disk state inconsistent when a pr… #187

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions src/hooks/useProjects.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,6 +99,7 @@ export function useProjects() {
async (ids: string[], category: string, destOrderedIds: string[]) => {
if (ids.length === 0) return
const moving = new Set(ids)
const snapshot = Array.isArray(projects) ? [...projects] : null
setData((prev) => {
if (!Array.isArray(prev)) return prev
const rank = new Map(destOrderedIds.map((pid, i) => [pid, i]))
Expand All @@ -116,12 +117,18 @@ export function useProjects() {
return p
})
})
for (const id of ids) {
await api.updateProject(id, { category })
try {
for (const id of ids) {
await api.updateProject(id, { category })
}
await api.reorderProjects(destOrderedIds)
} catch (e) {
if (snapshot) setData(snapshot)
await refresh()
throw e
}
await api.reorderProjects(destOrderedIds)
},
[setData],
[projects, refresh, setData],
)

const reorder = useCallback(async (orderedIds: string[]) => {
Expand Down
Loading