Repository navigation
Fix stale session settlement retry logic - #186
Merged
RykoTheDev merged 1 commit intoSep 22, 2026
Merged
Conversation
Fix settle stale sessions getting stuck after a failed initialization attempt due to OnceLock being permanently initialized. Replace the OnceLock guard with retryable state tracking using Mutex to Option to Instant and an AtomicBool to: allow retrying after find_running_godot_processes() fails; prevent concurrent settlement attempts; throttle successful settlement checks to once per minute; update the last successful settlement timestamp only after success. Add a test covering the Err Ok scenario to verify that a subsequent call successfully settles the stale session P.s sorry for my english is not my first language
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix settle stale sessions getting stuck after a failed initialization attempt due to OnceLock being permanently initialized.
Replace the OnceLock guard with retryable state tracking using Mutex to Option to Instant and an AtomicBool to:
allow retrying after find_running_godot_processes() fails; prevent concurrent settlement attempts;
throttle successful settlement checks to once per minute; update the last successful settlement timestamp only after success.
Add a test covering the Err Ok scenario to verify that a subsequent call successfully settles the stale session
P.s
sorry for my english is not my first language