Repository navigation
zeroize: run integration tests and doctests under Miri - #1586
Open
bardiharborow wants to merge 1 commit into
Open
bardiharborow wants to merge 1 commit into
bardiharborow wants to merge 1 commit into
Conversation
The Miri job ran `cargo miri test --lib`, but the crate has no unit tests in `src/`, so Miri was executing zero tests. Drop `--lib` so the integration tests in `tests/` and the doctests run under Miri too. Signed-off-by: Bardi Harborow <[email protected]>
bardiharborow
marked this pull request as ready for review
November 3, 2026 06:55
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Miri job ran
cargo miri test --lib, but the crate has no unit tests insrc/, so Miri was executing zero tests. This PR drops--libso the integration tests intests/and the doctests run under Miri too.