Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
examples/live.pyusetime.monotonic()instead oftime.time(), which can jump when the system clock is adjusted. Thepush()docstring asks for the capture time, or the time right after reading the frame.docs/results.mdnow covers only what is specific to Python and links to the shared guide at https://docs.rouast.com/guides/results/ for structure, keys, availability and confidence. It also corrects the rolling vitals description: they are on by default, underrolling_vitalswith the same keys asvitals, and data is returned as lists. Theestimate_rolling_vitalsdocstring is fixed to match.Checked, no change needed
Verification
pytest: 126 passed, 3 skipped.method="pos"onexamples/sample_video_1.mp4to confirm the result keys, types and rolling vitals described in the docs.