Repository navigation
Issue #6184: Simplified and optimized visibility check. - #6248
Merged
Merged
Conversation
stefanhaerter
force-pushed
the
issue-#6184-visibility_check_switch
branch
3 times, most recently
from
October 16, 2026 12:36
0b61bc2 to
aa47d69
Compare
Combined check for visibility and cached visibility in one statement and shifted it upward.
Fields which do set their content themselves (behavior SetsDynamicContent) also handle the hidden case themselves. Therefor, the hidden fields handling needs to be shifted behind the SetsDynamicContent block.
stefanhaerter
force-pushed
the
issue-#6184-visibility_check_switch
branch
from
October 19, 2026 06:01
aa47d69 to
928f43a
Compare
Reference driver needs to handle hiding and reappearing by itself. It needs to get passed on visibility changes as it can't determine them by itself. Evaluation needs to be skipped if field gets hidden. In that case, we reset the field to the stored value regardless if it is valid anymore. This is done to allow ACLs to be calculated properly.
stefanhaerter
force-pushed
the
issue-#6184-visibility_check_switch
branch
2 times, most recently
from
October 19, 2026 07:24
822f9a8 to
7d5ffef
Compare
Fixed logic: We want to check for changed value also in case visibility changed. Also, value changed check needs to run on data from GetParam, not from potentially already changed value.
stefanhaerter
force-pushed
the
issue-#6184-visibility_check_switch
branch
from
October 19, 2026 07:38
7d5ffef to
5ab470b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Combined check for visibility and cached visibility in one statement and
shifted it upward.
references #6184