feat(hardware): LIONv3 pre-review schematic - #14
Merged
Merged
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
Critical CANbus connectivity and protection/power wiring issues remain unresolved.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Updates the LIONv3 schematic to a pre-review state with CANbus, protection, power, symbol, and documentation changes.
Changes:
- Added CANbus circuitry, protection, and termination.
- Updated power protection, symbols, metadata, and project rules.
- Added editable and exported architecture diagrams.
File summaries
| File | Reviewed changes |
|---|---|
hardware/LIONv3/LIONv3.kicad_pro |
Project rules, netclasses, and CANbus registration. |
hardware/LIONv3/LIONv3-Symbols.kicad_sym |
Corrected custom symbol geometry and pin naming. |
hardware/LIONv3/CANbus.kicad_sch |
CAN transceiver, protection, and termination circuitry. |
docs/LIONv3-Diagram.svg |
Exported system architecture diagram. |
docs/LIONv3-Diagram.drawio |
Editable system architecture diagram. |
Review details
- Files reviewed: 3/11 changed files
- Comments generated: 5
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+1533
to
+1534
| (xy 91.44 48.26) (xy 91.44 49.53) | ||
| ) |
Comment on lines
+1633
to
+1634
| (xy 50.8 34.29) (xy 54.61 34.29) | ||
| ) |
Comment on lines
+1743
to
+1744
| (xy 151.13 36.83) (xy 151.13 35.56) | ||
| ) |
| ) | ||
| ) | ||
| ) | ||
| (property "Value" "PMEG2010ER" |
| (justify left) | ||
| ) | ||
| ) | ||
| (property "Datasheet" "https://www.st.com/resource/en/datasheet/esdal.pdf" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Brings the LIONv3 schematic up to the pre-review state. Scope ends at the schematic itself — review and approval still pending before PCB layout starts.
Protection and power
Fixes
Documentation and consistency
docs/LIONv3-Diagram.drawio) covering architecture, power distribution and external interfacesMISO→POCI,MOSI→PICO,NSS→nCS)KiCad symbols (
LIONv3-Symbols.kicad_sym)E80-900M2213S: pin positions corrected against datasheet, symbol rectangle extended for the new pin layoutANTrenamed toANT_2.4U14toU5Next steps