Handle Provider class method display_name - #16
Open
toddkummer wants to merge 1 commit into
Open
Conversation
This adds an Appraisal file for the main branch. Main includes references to `provider.class.display_name`, which breaks the encapsulation of the SimpleDelegator around the provider. The base Provider class already has an instance method `name` which does the same delegation (to `self.class.display_name`). If that was used instead of the direct call to `class`, then the delegation would hold. It might be worth asking about that. There are a small number of methods on Provider that defer back to `self.class`: slug, capabilities, configuration_requirements, and protocols. The name -> display_name is unique in that it is the only one that maps the method name, but the pattern is there. For now, this is handled by returning the dummy value "TestProvider".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds an Appraisal file for the main branch. Main includes references to
provider.class.display_name, which breaks the encapsulation of the SimpleDelegator around the provider.The base Provider class already has an instance method
namewhich does the same delegation (toself.class.display_name). If that was used instead of the direct call toclass, then the delegation would hold. It might be worth asking about that.There are a small number of methods on Provider that defer back to
self.class: slug, capabilities, configuration_requirements, and protocols. The name -> display_name is unique in that it is the only one that maps the method name, but the pattern is there.For now, this is handled by returning the dummy value "TestProvider".