Conversation
This will be CAIO's permanent supported repository now.
…into CAIO-3.3.5
Compare link
-Now handling multi block AIO messages Not tested, gonna test very soon.
Integrate upstream 3.3.5 (script modules, logging, RBAC, HotSwap) while preserving CAIO/AIO addon messaging, LuaVal scripts, and 1.75 protocol settings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CAIO adds C++ server-side handling for Rochet2/AIO (protocol 1.75) on TrinityCore 3.3.5.
Docs: doc/CAIO_README.md · message format · script example
Status
3.3.5(incl. new Linux/macOS/Windows workflows withsubmodules: recursive+WITH_CAIO_EXAMPLES).AddOnInit/ init-hook parity with stock AIO).Fixes in this update
Lifecycle / ownership
AIOHandlersafterSetScriptContext.AIOHandlers; unload no longer double-deletes.ScriptMgrscheduled-script counters (MapMgr already owns that).Commands / path
.caioSQL help matches parser order (addaddon name "file" [perm],sendall "msg" [perm]).AIO.ClientScriptPathbeforepath.back().Protocol
nvalidation (finite, integer, range).AIOMsgkeeps middlenilargs (stock arity); respectsMAX_BLOCK_ARGS.AIO PR #27 parity (keep protocol 1.75)
AIOCodec) and stateful reassembler (AIOReassembler); wiredPlayer/WorldSession.IsValidBlockArgCount.AIO.ForceReloadOnStartup(default on).[AIO]cases).Examples / docs / license
ExampleWindow.cppgated byWITH_CAIO_EXAMPLES(stub TU removed)./caioexampleslash helper.doc/CAIO_README.md(root pointer kept).CAIO LICENSE.txt(GPLv3). CAIO-owned units have no per-file TrinityCore GPLv2 banner (matches original SaiFi CAIO /AIOMsg); existing TC sources keep their headers. Documented in the README.Out of scope (v1)
Test plan
sql/CAIOapplied;.caio version/addaddon/sendsmoke-DWITH_CAIO_EXAMPLES=ON;/caioexample+ addon initnrejected cleanly in logs[AIO](18 cases) passed