Repository navigation
earmark_parser: Preserve code span whitespace - #175
Merged
Merged
Conversation
Earmark adopted full trimming and whitespace collapsing from CommonMark 0.28. CommonMark 0.29 changed the rule because whitespace can be significant in code spans. Preserve one-sided edge spaces and repeated internal spaces. Normalize line endings to spaces, and remove one edge space only when both edges contain spaces. Assisted-by: Codex:gpt-5
Owner
|
Thank you for your PR. |
Contributor
Author
|
Thanks for you work on Earmark! There is no rush. It was just something that I noticed when working on elixir-lang/ex_doc#2282 as it causes some inline code spans that are used like that to miss a space. |
Owner
|
Great job Thank You Do you want a release? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Earmark adopted full trimming and whitespace collapsing from CommonMark 0.28. CommonMark 0.29 changed the rule because whitespace can be significant in code spans.
Preserve one-sided edge spaces and repeated internal spaces. Normalize line endings to spaces, and remove one edge space only when both edges contain spaces.
I also fixed CI to work for Erlang/OTP 25 tests.