Conversation
 |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
|
|
||
| General game note example: | ||
| ``` | ||
| [General game notes] |
There was a problem hiding this comment.
This general note omits the address size required by this page, making the guidance inconsistent.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
| ``` | ||
| [32-bit] pointer to enemy object array | ||
| +0x00= [10x12 bytes] Enemy object array | ||
| +|0x00= [32-bit] ID | ||
| ..0x00= Monster A | ||
| ..0x01= Monster B | ||
| ..0x02= Monster C | ||
| +|0x04= [32-bit] Health | ||
| +|0x08= [32-bit] Model Pointer | ||
| +|+0x04= [Float] Position X | ||
| +|+0x08= [Float] Position Y | ||
| [6x4 bytes] Enemy object array | ||
| |0x00=Enemy ID [8-bit] | ||
| .0x00=Slime | ||
| .0x01=Ghost | ||
| .0x02=Wolf | ||
| |0x01=Enemy max HP [8-bit] | ||
| |0x02=Enemy current HP [8-bit] | ||
| |0x03=Enemy level [8-bit] | ||
| ``` |
There was a problem hiding this comment.
The warning follows only the pointer-array example, so readers may wrongly assume this new static-array notation is supported.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
|
|
||
| ### General Game Note | ||
|
|
||
| Occasionally, in order to more easily understand how a game functions, some general game notes are useful to inform maintainers. In cases where the refactorer feels a general game note will added significant benefit, it may be made on address 0x00000000 using the header **[General game notes]**. |
There was a problem hiding this comment.
“Will added” is ungrammatical, and “code node” conflicts with the established “code note” term on line 139. Both reduce clarity.
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
1 participant
Adds guidance on general game notes, provides an example of a static array, and cleans up some example formatting.