Skip to content

RFP landing follow-ups: proposal guide sidebar, funnel events, no "pool" - #1320

Merged
yattias merged 1 commit into
mainfrom
claude/landing-page-actionables-b934c1
Nov 21, 2026
Merged

yattias merged 1 commit into
mainfrom
claude/landing-page-actionables-b934c1

Conversation

@yattias

@yattias yattias commented Nov 21, 2026

Copy link
Copy Markdown
Member

Follow-ups from the 2026-11-20 call on the audit RFP landing page.

Workspace: a guide when you apply

  • Applying to any RFP opens the start screen with a guide beside the chat: the RFP's cover (links to the RFP), title, funder · amount · length, the parts a proposal should cover, and Read the RFP. Below 1100px of pane width it's a row under the composer that opens a bottom sheet.
  • /audit and /consciousness hand over guides written for them (PROPOSAL_GUIDE in each data/content.ts). Every other RFP (Apply on /rfp/…, or picked in the workspace) gets genericRfpGuide, which links back to the RFP's own page.
  • The composer opens with an unsent starter prompt with [blanks], the first one selected.
  • Removed the "Submitting an application to" card (the composer's RFP chip already names it; its workspace-applying-to testid moved to the chip for smoke/proposal.spec.ts). Visibility is now one grey line.

Landing pages

  • Audit: $100k goal; no tax claim; "See how to apply" in the hero and the sticky bar, opening a new "How do I apply?" FAQ.
  • Consciousness: "Tax deductible on qualifying contributions".
  • No "pool" on either page or in their funding panel ("Fund the audit" / "Fund the research"). Adds an optional successTitle prop to ContributeToFundraiseModal; other callers are unchanged.

Analytics: new Amplitude events

Network: each event is one request to the existing Amplitude endpoint, sent on the click or step it names. No new API calls.

Event Where Properties
rfp_how_to_apply_clicked /audit hero, sticky bar page, placement
rfp_submit_proposal_clicked /audit, /consciousness, every /rfp page (page: rfp) page, grant_id, open
rfp_fund_clicked same (on /rfp: Add to pool, phone Fund bar) page, grant_id, open
rfp_apply_started workspace, RFP handed over grant_id, has_guide
rfp_guide_read_clicked guide cover / button / sheet grant_id, placement
rfp_apply_message_sent first message from the start screen grant_id, has_guide, starter_unedited, blanks_left, signed_in
rfp_apply_draft_created chat creates the draft grant_id, note_id
rfp_application_submitted publish succeeds grant_id, post_id

has_guide is true only for a guide written for the RFP, not the generic one. On /rfp, Fund logs from the button click so it lands before the panel's fundraise_contribution_amount_step.

Testing

  • Locally against production data (read-only, signed out) on /audit, /consciousness, /rfp/33066 and /rfp/32943: the guide column and the phone row/sheet render, and every event above fires with its properties, except rfp_apply_draft_created and rfp_application_submitted, which need a signed-in account writing data.
  • Not checked live: picking an RFP inside the workspace (its list is blocked from localhost against the prod API).
  • npm run type-check, ESLint and Prettier pass (pre-commit).

Not in this PR

  • The audit (33884) and consciousness (33852) posts on production hold two sentences each, so the assistant's read_selected_rfp has little to go on. Their full call text needs pasting into the posts.

🤖 Generated with Claude Code

From the 2026-11-20 call on the audit landing page.

Workspace
- Applying to an RFP opens the start screen with a guide beside the chat
  (cover, title, facts, the parts a proposal needs, Read the RFP), or a
  row that opens a sheet where there is no room. Audit and consciousness
  hand over guides of their own; every other RFP gets a generic one that
  links back to its page.
- The composer opens with an unsent starter prompt, first blank selected.
- The "Submitting an application to" card is gone (the RFP chip names
  it); visibility is one grey line.

Landing pages
- Audit: $100k goal, no tax claim, "See how to apply" in the hero and the
  sticky bar opening a new "How do I apply?" FAQ.
- Consciousness: "tax-deductible on qualifying contributions".
- No "pool" on either page or in their funding panel ("Fund the audit",
  "Fund the research"; new successTitle prop on the contribute modal).

Analytics (Amplitude)
- rfp_how_to_apply_clicked, rfp_fund_clicked, rfp_submit_proposal_clicked,
  rfp_apply_started, rfp_guide_read_clicked, rfp_apply_message_sent,
  rfp_apply_draft_created, rfp_application_submitted.
- Fund and Apply on every /rfp page log with page: rfp; Fund logs before
  the panel's own amount step.

Co-Authored-By: Claude Opus 5.5 <[email protected]>
@yattias
yattias requested a review from a team as a code owner November 21, 2026 02:53
@vercel

vercel Bot commented Nov 21, 2026 •

Copy link
Copy Markdown
Contributor

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
web Ready Ready Preview Nov 21, 2026 2:54am UTC

Request Review

@chatgpt-codex-connector

Copy link
Copy Markdown
Codex Review Summary: ❌ Failed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ❌ Failed 2026-11-21T02:53:09.233145Z
We couldn’t complete this review. Comment @codex review to try again.
6cd6992 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

@sonarqubecloud

Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
5.3% Duplication on New Code (required ≤ 3%)
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@yattias
yattias merged commit 8068741 into main Nov 21, 2026
3 of 4 checks passed
@yattias
yattias deleted the claude/landing-page-actionables-b934c1 branch November 21, 2026 02:57

This branch was successfully deployed

1 active deployment
Preview — 6cd6992d Deployed Nov 21, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant